[$250] Bank account - Avatar icon for the owner is not legible in dark mode

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.16-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• App is in dark mode

1. Go to staging.new.expensify.com
2. Go to workspace settings > Workflows
3. Click Connect to bank account
4. Proceed to bank account set up
5. On Part 4, select Yes on the first step "Do you own 25% or more of Alberta Bobbeth Charleson?'
6. Select Yes on the next step "Do any individuals own 25% or more of Alberta Bobbeth Charleson?"
7. Enter all the required information (name, DOB, SSN and address)
8. Click Confirm on the confirmation page
9. Select No on the next step

Expected Result:

The avatar icon for the owner should be legible in dark mode

Actual Result:

The avatar icon for the owner is not legible in dark mode

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6560202_1722604353259.20240802_210721.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f1b46ddf957e4ce7
• Upwork Job ID: 1820455770779219098
• Last Price Increase: 2024-08-05
• Automatic offers:
• nyomanjyotisa | Contributor | 103407542

Issue Owner

Current Issue Owner: @mollfpr

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Avatar icon for the owner is not legible in dark mode

What is the root cause of that problem?

iconType prop missing here, so it default to CONST.ICON_TYPE_ICON, it should be CONST.ICON_TYPE_AVATAR

App/src/pages/ReimbursementAccount/BeneficialOwnerInfo/substeps/CompanyOwnersListUBO.tsx

Lines 118 to 128 in fefda46

	<MenuItem
	title={`${requestorData.firstName} ${requestorData.lastName}`}
	description={`${requestorData.requestorAddressStreet}, ${requestorData.requestorAddressCity}, ${requestorData.requestorAddressState} ${requestorData.requestorAddressZipCode}`}
	wrapperStyle={[styles.ph5]}
	icon={Expensicons.FallbackAvatar}
	iconWidth={40}
	iconHeight={40}
	interactive={false}
	shouldShowRightIcon={false}
	displayInDefaultIconColor
	/>

What changes do you think we should make in order to solve the problem?

Add iconType={CONST.ICON_TYPE_AVATAR} to the menu item above

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f1b46ddf957e4ce7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[mollfpr]

The proposal from @nyomanjyotisa looks good to me!

🎀 👀 🎀 C+ reviewed!