[HOLD for Payment 2024-08-26][$400] Accounting - NetSuite - No error message if no option is selected for segment display

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.14-2
Reproducible in staging?: Y
Reproducible in production?: Y
Found when validating PR : #46155
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Open the app
2. Log in with a new expensifail account
3. Click on FAB - New workspace
4. Enable "Accounting" in the "More features" page.
5. Navigate to "Accounting"
6. Connect to NetSuite and upgrade the workspace to Control when asked
7. Wait for the sync to finish
8. Navigate to Accounting - Import - Custom Segments/records
9. Click on the "Add custom segment/record" button
10. Start adding a custom segment with any rendom data until the "How should this custom segment be displayed in Expensify?" step
11. Click on the "Next" button without making a selection
12. Click on "fix the errors"

Expected Result:

There should be an error message to choose Tags or Report fields.

Actual Result:

No error message given if no option is selected for segment display. Nothing happens if I click on "fix the errors".

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6557338_1722345767013.bandicam_2024-07-30_15-19-57-971.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015eb22121c664b750
• Upwork Job ID: 1819084414296998813
• Last Price Increase: 2024-08-26
• Automatic offers:
• ikevin127 | Reviewer | 103426964
• cretadn22 | Contributor | 103426965

Issue Owner

Current Issue Owner: @ikevin127

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #wave-control.

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No error message if no option is selected for segment display

What is the root cause of that problem?

We shouldn't show the "Next" button when the page requires selecting options. For instance, in the initial step, the "Next" button is not displayed if the page is a selection list.

What changes do you think we should make in order to solve the problem?

1. We need to conceal the Next button if screenIndex === CONST.NETSUITE_CUSTOM_FIELD_SUBSTEP_INDEXES.CUSTOM_SEGMENTS.MAPPING

Adding isSubmitButtonVisible prop to FormProvider

isSubmitButtonVisible={screenIndex !== CONST.NETSUITE_CUSTOM_FIELD_SUBSTEP_INDEXES.CUSTOM_SEGMENTS.MAPPING}

Or we can add CUSTOM_SEGMENTS.MAPPING to this condition

App/src/pages/workspace/accounting/netsuite/import/NetSuiteImportCustomFieldNew/NetSuiteImportAddCustomSegmentPage.tsx

Line 195 in eced170

{screenIndex === CONST.NETSUITE_CUSTOM_FIELD_SUBSTEP_INDEXES.CUSTOM_SEGMENTS.SEGMENT_TYPE ? (

2. We need to move to the next page when the user selects an option

App/src/pages/workspace/accounting/netsuite/import/NetSuiteImportCustomFieldNew/NetSuiteCustomFieldMappingPicker.tsx

Line 32 in eced170

onSelectRow={(selected) => {

We need to include onNext(); as did here

App/src/pages/workspace/accounting/netsuite/import/NetSuiteImportCustomFieldNew/substeps/ChooseSegmentTypeStep.tsx

Lines 39 to 42 in eced170

	onSelectRow={(selected) => {
	setCustomSegmentType?.(selected.value);
	onNext();
	}}

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015eb22121c664b750

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[ikevin127]

Will review today.