Expensify Card - Empty state card is top centered instead of middle centered

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.14-2
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Launch New Expensify app.
2. Go to workspace settings.
3. Go to Expensify Card.

Expected Result:

The empty state card will be middle centered (production behavior).

Actual Result:

Empty state card is top centered instead of middle centered.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6557060_1722324180554.ScreenRecording_07-30-2024_15-18-34_1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #collect project.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

Coming from #45996

Justify content set to flex-start if isSmallScreenWidth true

App/src/pages/workspace/expensifyCard/EmptyCardView.tsx

Line 41 in 75be218

emptyStateForegroundStyles={isSmallScreenWidth && {justifyContent: 'flex-start'}}

What changes do you think we should make in order to solve the problem?

We should change that to the following to make it center like on production and with the new button margin

emptyStateForegroundStyles={isSmallScreenWidth && {top: -(BUTTON_HEIGHT + BUTTON_MARGIN)}}

What alternative solutions did you explore? (Optional)