[C+ Checklist Needs Completion] [$250] Contact method - Secondary contact method can not select Set as default

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.13-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+a751@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Login with new gmail account
2. Go to Account settings> Profile> Contact method> New contact method> Add new email> Add
3. Click on newly added secondary contact method> Complete the verification process
4. Click on the verified secondary contact method> Set as default

Expected Result:

There should be no error message. Since the secondary contact method becomes primary contact method - Set as default option should not be present

Actual Result:

"This is already your primary contact" error message appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6554036_1722022412832.Recording__3615.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012a16b21d55b907d8
• Upwork Job ID: 1818663412557629626
• Last Price Increase: 2024-08-07
• Automatic offers:
• ikevin127 | Reviewer | 103456590

Issue Owner

Current Issue Owner: @ikevin127

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[lanitochka17]

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Can't select secondary method as default on a new non-validated account.

What is the root cause of that problem?

When we have a non-validated account, add a secondary login, and then verify the secondary login, the BE actually sets the secondary login as the primary login. It can be verified from an email received after verifying, telling that the primary login has been changed to the secondary login. So, when we try to set the secondary login as the primary login, the BE responds with a message that the secondary login is already the primary login.

What changes do you think we should make in order to solve the problem?

If the BE behavior is expected, then we can fix this on the FE. What we want to do is, when validating a secondary login, if the primary login isn't validated yet, set the secondary login as the primary login on success verifying.

The loginList will be passed from the function params.

App/src/libs/actions/User.ts

Line 368 in 9901ca3

function validateSecondaryLogin(contactMethod: string, validateCode: string) {

if (!loginList[currentEmail].validatedDate) {
    successData.push(...[
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.ACCOUNT,
            value: {
                primaryLogin: contactMethod,
            },
        },
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.SESSION,
            value: {
                email: newDefaultContactMethod,
            },
        },
        ...,
    ]);
}

The data that requires update can be seen from the setContactMethodAsDefault optimistic data. (except the login list)

[melvin-bot]

@greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012a16b21d55b907d8