[HOLD for payment 2024-08-19] [$250] Xero - Onboarding modal shows up after refreshing page with 2FA setup prompt

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.11-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Account is connected to Xero
• 2FA is disabled after Xero is set up
• Expensifail account is used as it does not require onboarding

1. Go to staging.new.expensify.com
2. Log out if logged in
3. Log in to the account with Xero connected and 2FA disabled
4. After login, 2FA setup prompt will show up
5. Without setting up 2FA, refresh the page

Expected Result:

Onboarding modal will not show up after refreshing the page

Actual Result:

Onboarding modal shows up after refreshing the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6550548_1721742752377.20240723_203738.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0186166f403ad15af9
• Upwork Job ID: 1815869402034012020
• Last Price Increase: 2024-07-23

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 2

[mountiny]

This is most likely not a backend issue. cc @rushatgabhane. This seems to be mixing your changes with the ones from @filip-solecki and @WojtekBoman. Can you guys have a look, please?

[francoisl]

Either way, sounds like an edge case, going to demote to a daily issue for now.