[Awaiting checklist] [$250] iOS - App crashes on open and signin

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.9-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @coleaeason
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721306503767519

Action Performed:

1. Launch the app after update
2. Signin with valid credentials

Expected Result:

Able to launch/signin without any issues

Actual Result:

App crashes on open and after signin

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

RPReplay_Final1721345421.MP4

Cpu profile/trace:

{
"key": "1721311628959",
"time": "2024-07-18T14:07:08.959Z",
"level": "DEBUG",
"message": "[alrt] NewExpensify crash caught by error boundary - Cannot read property 'completeOnboarding' of null - {"errorInfo":"{\"componentStack\":\"\\n in HybridAppMiddleware\\n in EnsureSingleNavigator\\n in BaseNavigationContainer\\n in ThemeProvider\\n in NavigationContainerInner\\n in NavigationRoot\\n in DeeplinkWrapper\\n in Expensify\\n in withOnyx(Expensify)\\n in Unknown\\n in ColorSchemeWrapper\\n in ErrorBoundary\\n in BaseErrorBoundary\\n in ErrorBoundary\\n in SearchContextProvider\\n in KeyboardControllerView\\n in Unknown\\n in AnimatedComponent(Component)\\n in Unknown\\n in KeyboardProvider\\n in VideoPopoverMenuContextProvider\\n in VolumeContextProvider\\n in FullScreenContextProvider\\n in PlaybackContextProvider\\n in ReportIDsContextProvider\\n in ActiveWorkspaceContextProvider\\n in ActiveElementRoleProvider\\n in CustomStatusBarAndBackgroundContextProvider\\n in EnvironmentProvider\\n in PickerStateProvider\\n in ReportAttachmentsProvider\\n in ScrollOffsetContextProvider\\n in withOnyx(ScrollOffsetContextProvider)\\n in Unknown\\n in CurrentReportIDContextProvider\\n in PopoverContextProvider\\n in KeyboardStateProvider\\n in WindowDimensionsProvider\\n in RenderersPropsProvider\\n in ListStyleSpecsProvider\\n in SharedPropsProvider\\n in RenderRegistryProvider\\n in RenderHTMLConfigProvider\\n in TRenderEngineProvider\\n in BaseHTMLEngineProvider\\n in HTMLEngineProvider\\n in LocaleContextProvider\\n in withOnyx(LocaleContextProvider)\\n in Unknown\\n in WithCurrentUserPersonalDetails(Component)\\n in RNCSafeAreaView\\n in Unknown\\n in SafeArea\\n in PortalProviderComponent\\n in RNCSafeAreaProvider\\n in SafeAreaProvider\\n in ThemeIllustrationsProvider\\n in ThemeStylesProvider\\n in ThemeProvider\\n in AccountProvider\\n in withOnyx(AccountProvider)\\n in Unknown\\n in SessionProvider\\n in withOnyx(SessionProvider)\\n in Unknown\\n in Nvp_expensify_preferredEmojiSkinToneProvider\\n in withOnyx(Nvp_expensify_preferredEmojiSkinToneProvider)\\n in Unknown\\n in Nvp_expensify_frequentlyUsedEmojisProvider\\n in withOnyx(Nvp_expensify_frequentlyUsedEmojisProvider)\\n in Unknown\\n in PreferredThemeProvider\\n in withOnyx(PreferredThemeProvider)\\n in Unknown\\n in ReportDraftComment_Provider\\n in withOnyx(ReportDraftComment_Provider)\\n in Unknown\\n in BetasProvider\\n in withOnyx(BetasProvider)\\n in Unknown\\n in Nvp_private_blockedFromConciergeProvider\\n in withOnyx(Nvp_private_blockedFromConciergeProvider)\\n in Unknown\\n in CurrentDateProvider\\n in withOnyx(CurrentDateProvider)\\n in Unknown\\n in ReportActionsDrafts_Provider\\n in withOnyx(ReportActionsDrafts_Provider)\\n in Unknown\\n in PersonalDetailsListProvider\\n in withOnyx(PersonalDetailsListProvider)\\n in Unknown\\n in NetworkProvider\\n in withOnyx(NetworkProvider)\\n in Unknown\\n in ComposeProviders\\n in OnyxProvider\\n in ComposeProviders\\n in RCTView\\n in Unknown\\n in GestureHandlerRootView\\n in InitialURLContextProvider\\n in App\\n in RCTView\\n in Unknown\\n in RCTView\\n in Unknown\\n in AppContainer\"}"}"
},

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012a16cdc256e8dc37
• Upwork Job ID: 1814255257891977452
• Last Price Increase: 2024-07-19

Issue Owner

Current Issue Owner: @suneox

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mountiny]

cc @mateuuszzzzz

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012a16cdc256e8dc37

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - App crashes on open and signin.

What is the root cause of that problem?

Below useEffect in HybridAppMiddleware/index.ios.tsx can have NativeModules.HybridAppModule as null:

useEffect(() => {
    if (completedHybridAppOnboarding === undefined) {
        return;
    }

    Log.info(`[HybridApp] Onboarding status has changed. Propagating new value to OldDot`, true, {completedHybridAppOnboarding});
    NativeModules.HybridAppModule.completeOnboarding(completedHybridAppOnboarding);
}, [completedHybridAppOnboarding]);

What changes do you think we should make in order to solve the problem?

Add the below check:

if (completedHybridAppOnboarding === undefined || !NativeModules.HybridAppModule) {
    return;
}

[mountiny]

I have raised a quick PR, the commit was raised before seeing the proposal.

Running a build to see if it will fix it for those experiencing this issue