[HOLD for payment 2024-07-24] LHN not displayed after page refresh from settings page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.4-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @suneox
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1720062549074999

Action Performed:

1. Go to staging.new.expensify.com
2. Click Settings > About
3. Refresh the page

Expected Result:

Page reloads with out any issue

Actual Result:

LHN menu not displayed until navigated to other menu icon

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-07-04.at.10.06.45.mp4

Recording.295.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @iwiznia (AutoAssignerNewDotQuality)

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN not displayed after page refresh from settings page. Also, menu options inside the about page are not clickable.

What is the root cause of that problem?

Coin animation loading freezes the page.

App/src/pages/settings/AboutPage/AboutPage.tsx

Line 148 in 8ec71d6

illustration={LottieAnimations.Coin}

What changes do you think we should make in order to solve the problem?

We can do an async load of the animation in this way:

Add the below in Lottie/index.tsx:

const [animationFile, setAnimationFile] = useState<string | AnimationObject | {uri: string}>();

useEffect(() => {
    setAnimationFile(source.file);
}, [setAnimationFile, source.file]);

Now, update to return the below:

animationFile ? <LottieView
    // eslint-disable-next-line react/jsx-props-no-spreading
    {...props}
    source={animationFile}
    ref={ref}
    style={[aspectRatioStyle, props.style]}
    webStyle={{...aspectRatioStyle, ...webStyle}}
    onAnimationFailure={() => setIsError(true)}
/> : null

This will fix it for all usages of Lottie animations.

[suneox]

Thank @ShridharGoel proposal, but this issue also happens on other settings screens that use Lottie. This issue only started occurring in a few recent releases, so could you please find the offending PR?

[ShridharGoel]

@suneox It has started happening because we have switched to concurrent mode. We can fix this at all places using a common base logic for Lottie animations.

[suneox]

@suneox It has started happening because we have switched to concurrent mode.

@ShridharGoel Thank you. I also tried reverting the code before the merge commit #42592, and the issue doesn’t happen. It only occurs after commit d047467a enabled React concurrent mode.

We can fix this at all places using a common base logic for Lottie animations.

We don’t need to fix this at all places using Lottie; we just need to fix it in Lottie/index.tsx.

@iwiznia We can fix this issue based on this proposal and implement the fix in Lottie/index.tsx. I have tested it, and it works as expected.