[HOLD for payment 2024-08-14] [$250] When a room or report is renamed, the report action shows up using an old centered message style

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.3-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719556190081699

Action Performed:

1. Create a report in old dot and rename the report
2. Login to new dot and see report details
3. Create a room in NewDot and rename the room
4. Observe the centered report action.

Expected Result:

The RENAMED report action (ref) should use the newer system message style whereby the message comes from the user that took the action in grey font.

The format should be something like:

Tom Rhys Jones
renamed this room from #roomname to #newroomname

Given that, we also need to update the copy of the message slightly such that the actor is not included in the copy (i.e "You" in the screenshots) as the message is coming from the person that took the action.

Actual Result:

Renaming reports or rooms uses an old report action style. It looks like a normal chat message and it's centered on the report/chat.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0191d8611609765fe7
• Upwork Job ID: 1806689197252632356
• Last Price Increase: 2024-07-05
• Automatic offers:
• abdulrahuman5196 | Reviewer | 103146464
• neonbhai | Contributor | 103146466

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0191d8611609765fe7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

The RenameAction component uses the center aligned text styles:

App/src/components/ReportActionItem/RenameAction.tsx

Line 28 in 0c8bae5

<Text style={[styles.pv3, styles.ph5, styles.textAlignCenter, styles.textLabelSupporting]}>

App/src/components/ReportActionItem/RenameAction.tsx

Line 29 in 0c8bae5

<Text style={[styles.textLabelSupporting, styles.textStrong, styles.textAlignCenter]}>{displayName}</Text>

What changes do you think we should make in order to solve the problem?

We will remove the centered text and add other adjustments to align this component to comply with our figma designs.

here:

<Text style={[styles.pv3, styles.ph5, styles.textLabelSupporting]}>

<Text style={[styles.textLabelSupporting, styles.textStrong]}>{displayName}</Text>

[shawnborton]

Ah apologies, to clarify, we do not want to use this component, we want to use our standard system message component and get rid of the current component being used.