[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$250] QBO-incorrect toggle row style for Default vendor

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.83-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1717488551565489

Action Performed:

Prerequisite: Workspace connected with QBO

1. Go to staging.new.expensify.com
2. Click Settings > Workspace
3. Click on the workspace connected to QBO
4. Click Accounting > Export
5. Click Export company cards as
6. Observe the hint text for Default vendor

Expected Result:

Hint text is below the toggle

Actual Result:

Incorrect toggle row style for Default vendor

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a3aa3987291c1ed6
• Upwork Job ID: 1802761589599110203
• Last Price Increase: 2024-06-17
• Automatic offers:
• ikevin127 | Reviewer | 102780674
• truph01 | Contributor | 102780677

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[shawnborton]

cc @hayata-suenaga @trjExpensify

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect toggle row style for Default vendor

What is the root cause of that problem?

• In this component:
  

  App/src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx

  Line 67 in 9ddc788

  <ToggleSettingOptionRow

  
  we are using ToggleSettingOptionRow without shouldPlaceSubtitleBelowSwitch: true

What changes do you think we should make in order to solve the problem?

• We should use ToggleSettingOptionRow with shouldPlaceSubtitleBelowSwitch: true

What alternative solutions did you explore? (Optional)

Result

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a3aa3987291c1ed6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)