[$250] Room - Members number does not update in real time when user rejoin the room

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.80-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+a178@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Create room> Invite a member
2. Leave the room
3. Open the room again> Join
4. Go to header to open details page
5. Take a look at members section

Expected Result:

Members number should update since there is a new member in the room

Actual Result:

Members number does not update in real time when user rejoin the room. User must open Members page to update the info

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6505057_1717768640574.Recording__3142.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017450de92e982e995
• Upwork Job ID: 1799947003320904058
• Last Price Increase: 2024-06-09
• Automatic offers:
• dominictb | Contributor | 102720197

Issue Owner

Current Issue Owner: @allroundexperts

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[jainilparikh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Member count is not immediately updated when the User re-joins the chat. It is updated after the user clicks on 'Members' button.

What is the root cause of that problem?

When we open the side-pane (Which contains Members, Settings, Private notes etc) the state of a member does not get updated from the server.

What changes do you think we should make in order to solve the problem?

Update the number of member's by calling the server using the OPEN_ROOM_MEMBERS_PAGE action in ReportDetailsPage.tsx (https://github.com/Expensify/App/blob/main/src/pages/ReportDetailsPage.tsx) class by adding the following code:

    const getRoomMembers = useCallback(() => {
        if (!report) {
            return;
        }
        Report.openRoomMembersPage(report.reportID);
    }, [report]);

    useEffect(() => {
        getRoomMembers();
        // eslint-disable-next-line react-hooks/exhaustive-deps
    }, []);

What alternative solutions did you explore? (Optional)

Since, RoomMemberPage is using the same function, create this function in a common file so both classes can use it.

Verified that the above solution updates the member count appropriately.

Video:

screen-recording-2024-06-08-at-35138-pm_BWW7Ctyh.mp4

[jainilparikh]

@VictoriaExpensify , is this bug going to be marked as External or Help wanted so external contributors can pitch in ?

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room - Members number does not update in real time when user rejoin the room

What is the root cause of that problem?

The joinRoom function is not consistent with the inviteToRoom function.

Therefore, the inviteToRoom function adds the new participant to the report.participants array.

Unlike when joining a room, when the getVisibleChatMemberAccountIDs function is called, it has one less participant in the report.participants array

App/src/pages/ReportDetailsPage.tsx

Lines 92 to 100 in f3bb5a5

	const participants = useMemo(() => {
	if (isGroupChat) {
	return ReportUtils.getParticipantAccountIDs(report.reportID ?? '');
	}
	if (isSystemChat) {
	return ReportUtils.getParticipantAccountIDs(report.reportID ?? '').filter((accountID) => accountID !== session?.accountID);
	}
	return ReportUtils.getVisibleChatMemberAccountIDs(report.reportID ?? '');
	}, [report, session, isGroupChat, isSystemChat]);

The report.participants array won't be updated in real-time because the front end has not been synced with the backend.

Therefore, there will also be one less active member of the room.

App/src/pages/ReportDetailsPage.tsx

Lines 103 to 107 in f3bb5a5

	const activeChatMembers = participants.flatMap((accountID) => {
	const pendingMember = report?.pendingChatMembers?.findLast((member) => member.accountID === accountID.toString());
	return !pendingMember || pendingMember.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE ? accountID : [];
	});

What changes do you think we should make in order to solve the problem?

Let's make the joinRoom function consistent with the inviteToRoom function by optimistically adding the new participant before updating its notification preference.

Similar to the inviteToRoom function, this change helps with the expected offline behavior.

We can do this by replicating and modifying the code below to be suited for the joinRoom function.

App/src/libs/actions/Report.ts

Lines 2718 to 2729 in f3bb5a5

	const optimisticData: OnyxUpdate[] = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
	value: {
	participants: participantsAfterInvitation,
	pendingChatMembers,
	},
	},
	...newPersonalDetailsOnyxData.optimisticData,
	];

[VictoriaExpensify]

Keeping this as a low priority and adding it to the #vip_vsb project

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017450de92e982e995