[HOLD for payment 2024-06-20] Troubleshoot - App is stuck offline after "Force offline" toggled on and off

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.79-3
Reproducible in staging?: Y
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in to New Expensify
2. Navigate to Account settings > Troubleshoot
3. Toggle on and off the "Force offline" toggle

Expected Result:

The App should go online after switching off the "Force offline" toggle

Actual Result:

The App is stuck in the offline state. The offline indicator remains.
User is forced to either refresh the page or force-kill the app in order to return online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6502114_1717537103493.2024-06-04_19-08-15.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@pecanoro FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Troubleshoot - App is stuck offline after "Force offline" toggled on and off.

What is the root cause of that problem?

The below logic is wrong, setOfflineStatus expects isOffline kind of value but actually the opposite is being passed.

App/src/libs/NetworkConnection.ts

Lines 82 to 88 in 8dbec8d

	const isInternetReachable = Boolean(state.isInternetReachable);
	setOfflineStatus(isInternetReachable);
	Log.info(
	`[NetworkStatus] The force-offline mode was turned off. Getting the device network status from NetInfo. Network state: ${JSON.stringify(
	state,
	)}. Setting the offline status to: ${isInternetReachable}.`,
	);

What changes do you think we should make in order to solve the problem?

Change it to this:

NetInfo.fetch().then((state) => {
    const isOffline = !(state.isInternetReachable ?? false);
    setOfflineStatus(isOffline);
    Log.info(
        `[NetworkStatus] The force-offline mode was turned off. Getting the device network status from NetInfo. Network state: ${JSON.stringify(
            state,
        )}. Setting the offline status to: ${isOffline}.`,
    );
});

[ShridharGoel]

@pecanoro I can quickly open a PR if this is a blocker.

[neil-marcellini]

Frontend only bug. In fact, since this is a test tool only it shouldn't be a blocker at all