[$250] Distance - "Error loading messages" appears after dismissing invalid distance error

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.75-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #41481

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat that has no unsettled request
3. Go offline
4. Submit a distance expense with invalid addresses
5. Go online
6. Click on the distance preview
7. Dismiss the error message
8. Click on the header subtitle to return to the main chat
9. Scroll down

Expected Result:

There will be no "There was an error loading more messages." in the main chat

Actual Result:

"There was an error loading more messages." error shows up in the main chat after dismissing the error

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6489312_1716463242950.20240523_183441.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013c3c05166994ac09
• Upwork Job ID: 1795874267241521152
• Last Price Increase: 2024-08-08

Issue Owner

Current Issue Owner: @ishpaul777

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[jainilparikh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error message "There was an error loading more messages" is visible even when there is no error in the chat flow (The error is in the MoneyRequestView).

What is the root cause of that problem?

The error message "There was an error loading more messages" in the chat view is controlled by the flag: hasLoadingNewerReportActionsError which is a part of ReportMetadata. When we close the error modal (The modal that shows Route exceeded... ) this flag is not flipped.

What changes do you think we should make in order to solve the problem?

Create a new function in ReportActions.tsx as such:

function callOnxyMerge(reportID: string) {
    Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_METADATA}${reportID}`, {
        isLoadingInitialReportActions: false,
        hasLoadingNewerReportActionsError: false,
    });
}

and call that when the error modal closes, here:

https://github.com/Expensify/App/blob/main/src/components/ReportActionItem/MoneyRequestView.tsx#L356

This will flip the hasLoadingNewerReportActionsError flag to false, hence, when the user navigates back to the main chat view, the error message There was an error loading more messages won't be visible.

[melvin-bot]

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

Opening up to the community since we have a proposal.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013c3c05166994ac09