[HOLD for payment 2024-06-13] [HOLD for payment 2024-06-11] [$250] Tags settings – Unable to add Custom tag name in a new workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.74-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4561965
Email or phone of affected tester (no customers): applausetester+jp_e_category@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in.
3. Create new workspace
4. Click on More features and enable tags
5. Add 2 tags
6. Click on Settings and select Custom tag name
7. Enter Custom tag name and press Save

Expected Result:

Custom tag name in added

Actual Result:

Tag name is change and “Hmm… it’s not here” RHP appears when open it

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6481931_1715796719316.Custom_tag_name.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018e9f676195ac29b7
• Upwork Job ID: 1791187130986975232
• Last Price Increase: 2024-05-23
• Automatic offers:
• nkdengineer | Contributor | 102497235

Issue Owner

Current Issue Owner: @mananjadhav

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tag name is change and “Hmm… it’s not here” RHP appears when open it

What is the root cause of that problem?

When we enable policy tag, we don't create the optimistic data for policy tag so when we enable tag and open setting, custom tag name is empty and we can't edit this.

App/src/libs/actions/Policy.ts

Line 4206 in 5bfa295

function enablePolicyTags(policyID: string, enabled: boolean) {

What changes do you think we should make in order to solve the problem?

When we enable the tags feature, if the policyTagList doesn't exist we should create optimistic data for it the same as the image below

const policyTagList = allPolicyTags?.[policyID];
if (!policyTagList) {
    const defaultTagList: PolicyTagList = {
        Tag: {
            name: 'Tag',
            orderWeight: 0,
            required: false,
            tags: {}
        }
    }
    onyxData.optimisticData?.push({
        onyxMethod: Onyx.METHOD.SET,
        key: `${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`,
        value: defaultTagList,
    })
    onyxData.failureData?.push({
        onyxMethod: Onyx.METHOD.SET,
        key: `${ONYXKEYS.COLLECTION.POLICY_TAGS}${policyID}`,
        value: null
    })
}

App/src/libs/actions/Policy.ts

Line 4206 in 5bfa295

function enablePolicyTags(policyID: string, enabled: boolean) {

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018e9f676195ac29b7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[garrettmknight]

Reproduced and opened up. @mananjadhav what do you think of this first proposal?

[mananjadhav]

I just tested @nkdengineer's proposal it does seem to work. I was able to reproduce the error in the latest main, but when I was in a different branch the error didn't exist. I don't see any changes in enablePolicyTags. So I am not sure if we've got the correct root cause.