[HOLD for payment 2024-06-06] [$250] Workspace - RBR is aligned to top of WS bar

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.70-1
Reproducible in staging?: y
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition: Sign up new account.

1. Add workspace
2. Go to Workspace > Workflows
3. Enable 'Make or track payments'
4. Add VBA (Regions bank)
5. Go to Workspaces tab

Expected Result:

RBR is aligned to center of WS bar

Actual Result:

RBR is aligned to top of WS bar

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e565fa0b66eb131c
• Upwork Job ID: 1787654855430000640
• Last Price Increase: 2024-05-07
• Automatic offers:
• Krishna2323 | Contributor | 0

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kavimuru]

@isabelastisser FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - RBR is aligned to top of WS bar

What is the root cause of that problem?

Styles applied to icon container and the main View of ThreeDotMenuOrPendingIcon is incorrect.

App/src/pages/workspace/WorkspacesListRow.tsx

Lines 145 to 158 in 387ab0e

	<View style={[isNarrow && styles.mr5]}>
	{isJoinRequestPending && (
	<View style={[styles.flexRow, styles.gap2, styles.alignItemsCenter, styles.flex1, styles.justifyContentEnd, !isNarrow && styles.pr4, isNarrow && styles.workspaceListBadge]}>
	<Badge
	text={translate('workspace.common.requested')}
	textStyles={styles.textStrong}
	badgeStyles={[styles.alignSelfCenter, styles.badgeBordered]}
	icon={Expensicons.Hourglass}
	/>
	</View>
	)}
	{!isJoinRequestPending && (
	<>
	<View style={[styles.flexRow, styles.flex0, styles.gap2, isNarrow && styles.mr5, styles.alignItemsCenter]}>

What changes do you think we should make in order to solve the problem?

The icon container should not have the styles.flex0 styles and the main View of ThreeDotMenuOrPendingIcon should have the styles.flexRow style applied to it.

Also we need to apply styles to icon container for alignment and spacing for narrow layouts. We can create a style object like we do with isNarrow && styles.workspaceListBadge.

App/src/pages/workspace/WorkspacesListRow.tsx

Line 147 in 387ab0e

<View style={[styles.flexRow, styles.gap2, styles.alignItemsCenter, styles.flex1, styles.justifyContentEnd, !isNarrow && styles.pr4, isNarrow && styles.workspaceListBadge]}>

App/src/pages/workspace/WorkspacesListRow.tsx

Line 158 in 387ab0e

<View style={[styles.flexRow, styles.flex0, styles.gap2, isNarrow && styles.mr5, styles.alignItemsCenter]}>

isNarrow && {flexDirection: 'column', justifyContent: 'flex-start', marginLeft: 16, marginTop: 10},

What alternative solutions did you explore? (Optional)

Result

rbr_alignment_workspace_list_row.mp4

[Krishna2323]

Proposal Updated

• Updated main solution to make the stylings work in narrow layouts also

[Krishna2323]

Proposal Updated

• Added result video

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e565fa0b66eb131c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)