[HOLD for payment 2024-06-13] [$250] Search - Transaction report shows multiline title for expense with multiline description

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.70-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Submit expense
3. Submit an expense containing multiline description and no merchant
4. Click on the search icon
5. If the transaction report does not show up in Search list, go to transaction thread and edit the description while maintaining multiline format

Expected Result:

The transaction report in search list will show single line title

Actual Result:

The transaction report in search list shows multiline title

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6470040_1714741364474.20240503_205118.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01765f6dc12ad2c849
• Upwork Job ID: 1793043171906035712
• Last Price Increase: 2024-05-21
• Automatic offers:
• DylanDylann | Reviewer | 102449287
• nkdengineer | Contributor | 102449290

Issue Owner

Current Issue Owner: @kevinksullivan

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@kevinksullivan FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The transaction report in search list shows multiline title

What is the root cause of that problem?

In HeaderView or LHN, we use DisplayNames component to show to report name and it used ReportUtils.formatReportLastMessageText function to replace all break line to space character.

App/src/components/DisplayNames/DisplayNamesWithTooltip.tsx

Line 59 in 2f5173c

? ReportUtils.formatReportLastMessageText(fullTitle)

But in UserListItem, we don't do this so the bug happens in the finder page.

App/src/components/SelectionList/UserListItem.tsx

Line 122 in 2f5173c

text={Str.removeSMSDomain(item.text ?? '')}

What changes do you think we should make in order to solve the problem?

We should do the same way as we do here to replace all line break when display the title of UserListItem

text={ReportUtils.formatReportLastMessageText(Str.removeSMSDomain(item.text ?? ''))}

App/src/components/SelectionList/UserListItem.tsx

Line 122 in 2f5173c

text={Str.removeSMSDomain(item.text ?? '')}

What alternative solutions did you explore? (Optional)

Or we can format formattedName in getReportName function to replace line break with space as we do here

App/src/libs/ReportUtils.ts

Line 3223 in e8ae3c5

return formattedName;

[melvin-bot]

@kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

[kevinksullivan]

Hm I am not experiencing this error @lanitochka17 . The search result shows as one line, even when I Am I misunderstanding?

[lanitochka17]

@kevinksullivan Need to create two transactions.

bandicam.2024-05-10.22-38-48-411.mp4

[melvin-bot]

@kevinksullivan Eep! 4 days overdue now. Issues have feelings too...