[$250] Approve - "Waiting for you to pay" message appears briefly for approver after approving report

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.66-2
Reproducible in staging?: Y
Reproducible in production?: Y
Found when validating PR: #40532
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Collect workspace has another user as approver.

1. Go to staging.new.expensify.com
2. [Admin] Go to workspace chat.
3. [Admin] Create an expense and submit the report.
4. [Approver] Go to transaction thread.
5. [Approver] Click Approve button.

Expected Result:

Approver will not be presented with this Next step message "Waiting for you to pay these expenses".

Actual Result:

"Waiting for you to pay these expenses" message appears briefly for approver after approving the report.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6462601_1714121004492.bandicam_2024-04-26_16-36-46-329.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013e61cf7fb38074ac
• Upwork Job ID: 1785010427319132160
• Last Price Increase: 2024-05-14
• Automatic offers:
• eh2077 | Reviewer | 0
• GandalfGwaihir | Contributor | 0

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wrong optimistic message is seen for the approver who is not the owner of the policy

What is the root cause of that problem?

Currently in NextStepsUtils, we do not cover the case where the approver is not the owner of the policy, this causes the current regression, as first we will show the optimistic message which will be set to waiting for you to pay...:

App/src/libs/NextStepUtils.ts

Lines 302 to 308 in 3f379ec

	if (!isOwner) {
	optimisticNextStep.message = [
	{
	text: 'Waiting for ',
	},
	{
	text: managerDisplayName,

here the managerDisplayName would be set to you as :

App/src/libs/NextStepUtils.ts

Line 91 in 3f379ec

const managerDisplayName = isSelfApproval ? 'you' : ReportUtils.getDisplayNameForParticipant(submitToAccountID) ?? '';

isSelfApproval will be true as the current account id would be equal to the approver/submitter account id:

App/src/libs/NextStepUtils.ts

Line 89 in 3f379ec

const isSelfApproval = currentUserAccountID === submitToAccountID;

What changes do you think we should make in order to solve the problem?

We need to add new code which will check if the current user is the approver of the policy but isn't the owner of the policy, and then we will set the optimistic message for this case which will match with the BE returned value:

case CONST.REPORT.STATUS_NUM.APPROVED:
            if (isManager && !isOwner) {
                optimisticNextStep = {
                    type,
                    title: 'Finished!',
                    message: [
                        {
                            text: 'No further action required!',
                        },
                    ],
                };
            } else {
            ..... (The current existing code)

Note: instead of isManager to be more careful we can check submitToAccountID === currentUserAccountID, but that can be discussed during PR stage

Results

Screen.Recording.2024-04-27.at.4.16.23.AM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013e61cf7fb38074ac

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)