Skip to content

Any links pasted into e.cash that includes a colon : break causing only the portion before the colon to be hyperlinked  #4105

Description

@isagoico

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in to e.cash and navigate to a conversation
  2. Paste and send these links that contain colons:
    A. https://www.google.com/maps/place/%E9%9D%92%E5%B3%B6%E9%80%A3%E7%B5%A1%E8%88%B9%E4%B9%97%E5%A0%B4/@33.7363156,132.4877213,17.78z/data=!4m5!3m4!1s0x3545615c8c65bf7f:0xb89272c1a705a33f!8m2!3d33.7366776!4d132.4878843
    B. https://www.google.com/maps/place/The+Flying+Saucer/@42.4043314,-86.2742418,15z/data=!4m5!3m4!1s0x0:0xe28f6108670216bc!8m2!3d42.4043316!4d-86.2742121
  3. Notice that the links are cut off after the colon and therefore don't hyperlink correctly.

Expected Result:

Links including colons should be correctly hyperlinked. In this example when clicked, should redirect to:
A. The cat island in Japan (and yes, it's an island full of cats)
B. The Flying Saucer in South Haven, MI

Actual Result:

Both links are not hyperlinked correctly and cut off after the colon.
image

Workaround:

User has to manually select the full link and paste it in the URL bar.

Platform:

Where is this issue occurring?

Web ✔️
iOS ✔️
Android ✔️
Desktop App ✔️
Mobile Web ✔️

Version Number: 1.0.79-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:
Most Google Maps links are affected by this because they contain colons in the URL.
Please check the screenshot in Actual result.
I will try different links from other sites and, if I find more affected by this, will post the ones that have the same issue in comments.

Upwork Post: https://www.upwork.com/jobs/~017aff792b5b4f4a79

View all open jobs on Upwork


From @mallenexpensify https://expensify.slack.com/archives/C01GTK53T8Q/p1626278479245000

Links pasted into chats sometimes get cut off and the full link isn't properly hyperlinked in a message, especially for Google Maps links.

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions