[Awaiting checklist] [$250] Distance Request -"Distance" option does not appear in QAB for a gmail account

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.64-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Issue found when executing PR #39413

Action Performed:

1. Open the testing app and login with a gmail account
2. Submit an expense request using Distance request
3. Click on FAB menu and select "Record distance" from the QAB

Expected Result:

User should be navigated to the Distance tab

Actual Result:

No Distance tab / user is directed to the Manual request tab

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6458086_1713825666275.Screen_Recording_2024-04-23_at_1.13.14_AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013f4eac573fdf1cb2
• Upwork Job ID: 1783176218489765888
• Last Price Increase: 2024-05-01
• Automatic offers:
• getusha | Reviewer | 0
• nkdengineer | Contributor | 0

Issue Owner

Current Issue Owner: @getusha

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We show P2P details for submit expense distance even when the user is not under beta

What is the root cause of that problem?

In chat options:

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Line 109 in c90b46e

const chatOptions = OptionsListUtils.getFilteredOptions(

We currently only check if the action is not isCategorizeOrShareAction and show the personal contact without checking if p2p beta access is allowed to the user or not:

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Line 136 in c90b46e

!isCategorizeOrShareAction,

App/src/libs/OptionsListUtils.ts

Line 1995 in f421923

includePersonalDetails = true,

Note as comments #40790 (comment), P2P distance is still in beta so we need to hide the personal details in this case

What changes do you think we should make in order to solve the problem?

We have extra checks in place for P2P distance beta already during filtering :

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Line 121 in c90b46e

(canUseP2PDistanceRequests || iouRequestType !== CONST.IOU.REQUEST_TYPE.DISTANCE) && !isCategorizeOrShareAction,

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Line 128 in c90b46e

(canUseP2PDistanceRequests || iouRequestType !== CONST.IOU.REQUEST_TYPE.DISTANCE) && !isCategorizeOrShareAction,

So we should follow the same pattern and update the !isCategorizeOrShareAction, to !isCategorizeOrShareAction && (canUseP2PDistanceRequests || iouRequestType !== CONST.IOU.REQUEST_TYPE.DISTANCE),

--- a/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js
+++ b/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

@@ -124,26 +122,14 @@ function MoneyTemporaryForRefactorRequestParticipantsSelector({participants, onF
             undefined,
             undefined,
             undefined,
-            !isCategorizeOrShareAction,
+            !isCategorizeOrShareAction && (canUseP2PDistanceRequests || iouRequestType !== CONST.IOU.REQUEST_TYPE.DISTANCE),
             isCategorizeOrShareAction ? 0 : undefined,
         );

Result:

[twisterdotcom]

@neil-marcellini keen for your take on this one, so going to make you the internal reviewer ahead of time. I agree though, it's odd to allow a QAB but not direct to it.

40790.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013f4eac573fdf1cb2