[HOLD for payment 2024-06-13] [$250] Does not show the chat room in the results when searching for the rooms user is a part of

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-11
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @coleaeason
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713480493902799

Action Performed:

1. Join any public room
2. Search for the room using search icon

Expected Result:

Search results should display the result in which the user is a part of

Actual Result:

No results found error message appears
For @davidcardoza Shows the results for any room which are pinned

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.3009.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015b0a0277b5ad4344
• Upwork Job ID: 1782705413299757056
• Last Price Increase: 2024-04-30
• Automatic offers:
• akinwale | Reviewer | 0

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[saifelance]

@m-natarajan The current behaviour looks ok

[dragnoir]

Proposal

Please re-state the problem that we are trying to solve in this issue.

when searching for the rooms user is a part of, the room doesn't appear on the serach result

What is the root cause of that problem?

on ChatFinderPage, the useOptionsList does not turn the rooms where the user is invited to.

https://github.com/Expensify/App/blob/aa6e8c6182935acd79cc78356342f3cc61bbe6db/src/pages/ChatFinderPage/index.tsx#L59C46-L59C60

The two functions from OptionsListUtils used to create the optiosn list createOptionList and getOptions had this tine of code:

App/src/libs/OptionsListUtils.ts

Lines 1478 to 1480 in aa6e8c6

	if (!accountIDs || accountIDs.length === 0) {
	return;
	}

The invited user to a public room is not allowed to check the list and details of the room users, where accountIDs.length === 0 is true.

What changes do you think we should make in order to solve the problem?

We need to check if the report is a chat room if accountIDs.length === 0

update here and here to

if ((!accountIDs  ||  accountIDs.length  ===  0) &&  !isChatRoom) {
  return;
}

POC:

20240421_222833.mp4

We can discuss more throw the PR how to make sure it's an invited chat room report.

[saifelance]

@dragnoir

This issue stems from a condition in the createOptionList and getOptions functions in OptionsListUtils.ts.

To address this issue, you proposed modifying the condition to also check if the report is a chat room before returning if accountIDs.length === 0. Here's how you could implement this change:

if ((!accountIDs || accountIDs.length === 0) && !isChatRoom) { return; }

[saifelance]

@dragnoir Correct
users should indeed be able to search for and find public chat rooms that they have joined.

You can modify the condition to ensure that public chat rooms are included in the search results.

if ((!accountIDs || accountIDs.length === 0) && !isChatRoom && !isPublic) { return; }

By adding !isPublic to the condition, you ensure that public chat rooms are not excluded from the search results. This change allows users to search for and find public chat rooms they have joined.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015b0a0277b5ad4344