CRITICAL: [Track Expense] [$500] Track Expense sometimes opens the participant selector

[thienlnam]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

1. Create a new account
2. Track Expense
3. After entering an amount, click 'Next'

Expected Result:

You should see a final confirmation page, instead of seeing a participant selector page

Actual Result:

You see a participant selector page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
None - usually fixes itself by opening up the selfDM

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01184eaa749eca16a8
• Upwork Job ID: 1780001858353557504
• Last Price Increase: 2024-04-19
• Automatic offers:
• hungvu193 | Contributor | 0
• nkdengineer | Contributor | 0

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Track Expense sometimes opens the participant selector

What is the root cause of that problem?

The problem is rather related to the fact that when we create a new account
At the time of creating Track Expense we have incorrect reportID

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Lines 128 to 132 in 9902923

	if (report?.reportID) {
	IOU.setMoneyRequestParticipantsFromReport(transactionID, report);
	Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_CONFIRMATION.getRoute(CONST.IOU.ACTION.CREATE, iouType, transactionID, reportID));
	return;
	}

What changes do you think we should make in order to solve the problem?

To fix this issue we can update this condition and add isTrackExpenseReport using this function
To be sure that in the case of Track Expense we always navigate to the correct screen

const isTrackExpenseReport = ReportUtils.isTrackExpenseReport(report);

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Lines 128 to 132 in 9902923

	if (report?.reportID) {
	IOU.setMoneyRequestParticipantsFromReport(transactionID, report);
	Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_CONFIRMATION.getRoute(CONST.IOU.ACTION.CREATE, iouType, transactionID, reportID));
	return;
	}

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01184eaa749eca16a8

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

• In here we generate a new reportID if we cannot find a seftDM from ReportUtils.findSelfDMReportID (This occur when the selfDM's data is not available)
• Then in here we have a logic to navigate user to participants page if report.reportID is undefined. In the case of the bug, report?.reportID is undefined

What changes do you think we should make in order to solve the problem?

• We need to subscribe the ONYXKEYS.IS_LOADING_REPORT_DATA in here.
• Then, disable or remove the option "track-expense" in FAB if the selfDM's data is not available. Do it by updating this to:

                    ...(canUseTrackExpense && selfDMReportID

with selfDMReportID = ReportUtils.findSelfDMReportID()

• We also need to prevent user from going to the track-expense flow if the selfDM's data is not available as well

What alternative solutions did you explore? (Optional)

• We need to add the check if the iouType is track-expense along with report?.reportID

        if (report?.reportID || iouType === CONST.IOU.TYPE.TRACK_EXPENSE) {

• Also, currently, we can access the participants page via deeplink, we need to fix it. If the current request type is track-expense, and then the user tries to open participants page, we will display "Hmm It's not here" page or navigate the user to the start page or confirmation page. For example, in here, add:

    useEffect(() => {
        if (iouType === CONST.IOU.TYPE.TRACK_EXPENSE) {
            Navigation.isNavigationReady().then(() => {
                navigateBack()
            });
        }
    }, [iouType, navigateBack]);

[hungvu193]

Taking over this issue as C+ per this discussion: https://expensify.slack.com/archives/C02NK2DQWUX/p1713272014981619
cc @ntdiary