[WAITING ON #40059][$250] Conversation - Deleted message reappears when reopening the conversation

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.59
Reproducible in staging?: Y
Reproducible in production?: Y
**If this was caught during regression testing, add the test name, ID and link from TestRail:**N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Open the https://staging.new.expensify.com/
   website.
2. Tap on the chat icon.
3. Open any conversation.
4. Long press on any sent message.
5. Tap on "Delete Comment"
6. Tap on "Delete"
7. Tap on the arrow on the top left corner.
8. Tap on the same conversation again.
9. Check if the deleted message is still displayed or was succesfully deleted

Expected Result:

Deleted message shouldn´t reappear after closing and reopening the conversation

Actual Result:

Deleted message reappears on the chat after closing it and reopening it

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6434653_1711994994698.Delete.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011225f8750b0176de
• Upwork Job ID: 1777801993580064768
• Last Price Increase: 2024-05-07

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Conversation - Deleted message reappears when reopening the conversation

What is the root cause of that problem?

It is regression after this changes.

With the current implementation it will only delete the report action if it is a parent action of some thread ( with other words the report action has child report ). Otherwise here we remove DeleteComment from persistedRequests and prevent sending request to the server.

It would be better to know in what cases we should prevent a request from being sent to the server before proposing a solution. But at this stage I will still offer two different options.

What changes do you think we should make in order to solve the problem?

looking at isDeletedParentAction, I understand that we only want to delete the report action which is parent, but we haven't calculated that if the report activity doesn't have a child report, it won't be a parent. So that we should delete the report action if it is a parent or just has not child report

1. Define new variable hasThreadMessage in deleteReportComment function

const hasThreadMessage = !!reportAction.childReportID`

2. Update this condition to !hasThreadMessage || isDeletedParentAction

What alternative solutions did you explore? (Optional)

Remove WRITE_COMMANDS.DELETE_COMMENT from this array or transfer it in above array

[melvin-bot]

@johncschuster Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011225f8750b0176de

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)