Skip to content

HIGH: [Performance] Stop logging huge ID lists when nothing changes #38904

Description

@quinthar

Problem:

When merging an Onyx value, it can sometimes log huge lines -- even if nothing changes. This is not just confusing when looking at the logs, but is probably slowing down the app (because logging is in general slow, and logging a 15KB logline pointlessly isn't great, especially when using "local logging" in mobile, which stores everything to Onyx, crippling the app after a few minutes).

Solution:

Only log the actual keys that change. I think @marcaaron might have already done this as mentioned here, but tracking it in this issue.

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions