[HOLD for payment 2024-04-15] [$500] Attachments - Next video starts playing when change Playback speed

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

**Version Number:**1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+balto915@gmail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #37425

Action Performed:

1. Upload few videos to one chat
2. Expand the first video
3. Go to the 3-dots menu> Playback speed> Change the speed

Expected Result:

Video playing speed should be changed

Actual Result:

When change one video speed next video starts playing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6423497_1711131431269.Recording__2677.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d33a91241a495ee7
• Upwork Job ID: 1772739460916158464
• Last Price Increase: 2024-03-26
• Automatic offers:
• ShridharGoel | Contributor | 0

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@johncschuster FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Next video starts playing when change playback speed or next attachment opens.

What is the root cause of that problem?

withoutOverlay is being passed as true in the PopoverMenu.

App/src/components/VideoPopoverMenu/index.tsx

Lines 31 to 40 in 191d932

	<PopoverMenu
	onClose={hidePopover}
	onItemSelected={hidePopover}
	isVisible={isPopoverVisible}
	anchorPosition={anchorPosition}
	menuItems={menuItems}
	anchorRef={videoPlayerMenuRef}
	withoutOverlay
	/>
	);

Because of this, the playback speed options popover doesn't have an overlay behind it. So, when an option is selected, the click goes to the 'next' option behind the playback speed menu, and it moves to the next attachment.

What changes do you think we should make in order to solve the problem?

withoutOverlay should not be passed to PopoverMenu from VideoPopoverMenu.

<PopoverMenu
    onClose={hidePopover}
    onItemSelected={hidePopover}
    isVisible={isPopoverVisible}
    anchorPosition={anchorPosition}
    menuItems={menuItems}
    anchorRef={videoPlayerMenuRef}
/>

Playback.mov

[ShridharGoel]

@johncschuster Can you check this when possible?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d33a91241a495ee7