[HOLD for payment 2024-03-26] Tag name field is missing a right caret

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.52-6
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710462014541529

Action Performed:

1. Go to any "collect" workspace
2. Click tags >settings
3. Observe the tag name field

Expected Result:

Tag name field should have a right caret

Actual Result:

Tag name field is missing a right caret

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tag name field is missing a right caret

What is the root cause of that problem?

We don't add right icon in MenuItemWithTopDescription

App/src/pages/workspace/tags/WorkspaceTagsSettingsPage.tsx

Lines 75 to 79 in f1f22c7

	<MenuItemWithTopDescription
	title={policyTagName}
	description={translate(`workspace.tags.customTagName`)}
	onPress={() => Navigation.navigate(ROUTES.WORKSPACE_EDIT_TAGS.getRoute(route.params.policyID))}
	/>

What changes do you think we should make in order to solve the problem?

We should enable shouldShowRightIcon in MenuItemWithTopDescription here

                                <MenuItemWithTopDescription
...
                                    shouldShowRightIcon
                                />

What alternative solutions did you explore? (Optional)

NA

Result

[luacmartins]

I'll work on this one. It's a really simple fix.