[HOLD for payment 2024-03-26] [$250] [Simplified Collect][More Features] Optimistically set defaults for Workflows if feature is disabled

[luacmartins]

Coming from this PR, we need to optimistically set the default values for the workspace if the workflows feature is disabled, i.e.

• Scheduled Submit (Delayed Submission) off (harvesting.enabled = false)
• No approvals (Submit & close) - approval mode OPTIONAL
• Reimbursement choice - reimburseNo

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Optimistically set defaults for Workflows if feature is disabled

What is the root cause of that problem?

• In here, when turning off the policy workflow, we do not has optimistic data for the related keys, for example, approvalMode, areWorkflowsEnabled, autoReporting, harvesting.enabled, reimbursement.choice.reimbursementChoice, ...

What changes do you think we should make in order to solve the problem?

• We need to set the above optimistic data once we turn off policy workflow.

 const optimisticDataWhenDisabled = [
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
            value: {
                approvalMode: CONST.POLICY.APPROVAL_MODE.OPTIONAL,
                autoReporting: false,
                harvesting: {
                    enabled: false,
                },
                reimbursement: {choice: {reimbursementChoice: CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO}},
                reimbursementChoice: CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO,
            },
        },
    ];

• We can add the above optimistic data to the optimisticData in here if enabled: false

• If the API is called failed, update the failureData as well.

What alternative solutions did you explore? (Optional)

• NA

[nkdengineer]

@luacmartins Can a contributor work on this issue? I can open the PR in a day. Thanks

[mountiny]

@nkdengineer its a straightforward change, I will export this for $250

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.