[$250] Mention - @expensify.sms is copied along with phone number when copied to clipboard

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.51-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #37559

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat
3. Send a text with phone number mention
4. Right click on the message > Copy to clipboard
5. Paste the content in the composer

Expected Result:

@expensify.sms will not be copied along with phone number

Actual Result:

@expensify.sms is copied along with phone number

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6411578_1710278333139.20240313_051600.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e5f15c665b86efd4
• Upwork Job ID: 1772750767801118720
• Last Price Increase: 2024-04-02
• Automatic offers:
• alitoshmatov | Reviewer | 0

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Mention - @expensify.sms is copied along with phone number when copied to clipboard

What is the root cause of that problem?

• In here we are using the messageHtml to get the copy text in case of this bug

What changes do you think we should make in order to solve the problem?

• We can use:

    setClipboardMessage(content.replace(/(<mention-user>)(.*?)(<\/mention-user>)/gi, function(match, openTag, content, closeTag) {
                        // Replace email addresses inside content with *****
                        content = content.replace(new RegExp(EMAIL_PART, "gim"), (match)=>Str.removeSMSDomain(match))
                        // Return the modified content inside the tags
                        return openTag + content + closeTag;
                    }));

in here and here

• In the above,
  (<mention-user>)(.*?)(<\/mention-user> is the regex matching all the text inside mention-user tag, which will handle the case user types "xxxx@expensify.com" directly, in this case, we should not remove the "@expensify.com", EMAIL_PART = ([\\w\\-\\+\\'#]+(?:\\.[\\w\\-\\'\\+]+)*@(?:[\\w\\-]+\\.)+[a-z]{2,})" is regex matching an text containing an email (we already used it in here)

• Or we can just use:

  setClipboardMessage(content.replace(/(<mention-user>)(.*?)(<\/mention-user>)/gi, function(match, openTag, content, closeTag) {
                        content = Str.removeSMSDomain(content);
                        return openTag + content + closeTag;
                    }));

What alternative solutions did you explore? (Optional)

• We also can update this to:

            const messageHtml = Str.removeSMSDomain(getActionHtml(reportAction));

[melvin-bot]

@greg-schroeder Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@greg-schroeder Still overdue 6 days?! Let's take care of this!

[greg-schroeder]

Apologies, I was OOO last week. I'll take a look at this shortly

[greg-schroeder]

Adding to #vip-vsb as this is chat-related, and I'm pretty sure this is very simple.