[HOLD for payment 2024-04-05] [$500] [Performance] Memoize SidebarLinksData to reduce the getOrderedReportIDs calls

[mountiny]

Coming from the Callstack performance audit

From the hermes profile trace, we see that getOrderedReportIDs from Sidebarlinks takes about ~8 seconds and it happens in 3 occurrences. Which means we have getOrderedReportIDs being called for roughly 3 times. We can reduce it to 2 times only by adding memoization to Sidebarlinks . This reduces the app startup by ~2.5 seconds, which is a huge reduction.
Details for the implementation can be seen in the commit

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011e08e65659afcb69
• Upwork Job ID: 1772400240247611392
• Last Price Increase: 2024-03-25

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mountiny]

@rinej can you please comment here so I can assign you?

[rinej]

@mountiny sure

[mountiny]

Thanks

[rinej]

Hello @mountiny, we decided to hold this off until we complete the remaining audit implementations because as of now, we are not yet sure whether we prefer the extra render without memo or increased rendering time with memo. We will evaluate this after all the audit action items are completed.