[$500] Android - Connect manually button does not trigger haptic feedback vibration

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.48-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #37108

Action Performed:

1. Navigate to WS settings
   2.Tap Bank account
   3.Tap and long press on Connect manually button

Expected Result:

Feedback vibration should occur (As occurring when long pressed on Connect with Plaid button)

Actual Result:

No haptic vibration occurs if long pressed on the button Connect manually
Note: It is a new feature, so can not be tested in Production

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6405094_1709799829971.mobizen_20240307_110425.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f1461856a7e2c854
• Upwork Job ID: 1765956089934372864
• Last Price Increase: 2024-03-08

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

We think that this bug might be related to #wave8
CC @zanyrenney

[lanitochka17]

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Connect manually button does not trigger haptic feedback vibration

What is the root cause of that problem?

Haptic feedback functionality is not enabled for connect manually.

App/src/pages/ReimbursementAccount/BankAccountStep.js

Lines 154 to 166 in 86a9904

	<View style={[styles.mv3]}>
	<MenuItem
	icon={Expensicons.Connect}
	title={props.translate('bankAccount.connectManually')}
	disabled={!props.user.validated}
	onPress={() => {
	removeExistingBankAccountDetails();
	BankAccounts.setBankAccountSubStep(CONST.BANK_ACCOUNT.SETUP_TYPE.MANUAL);
	}}
	shouldShowRightIcon
	wrapperStyle={[styles.cardMenuItem]}
	/>
	</View>

What changes do you think we should make in order to solve the problem?

Use Button instead of MenuItem like it is being done for connect with plaid option.
Then, shouldEnableHapticFeedback needs to be passed as true in Button for the connect manually button.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f1461856a7e2c854

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)