Wrong report title for expensify card transactions

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction ( don't have expensify card transactions)
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1709735584075159

Action Performed:

1. Go to a workspace chat as employee
2. Create expensify card transaction report and submit to approver
3. Sign in to approver accoun and open the expense report

Expected Result:

Should be "employee email address spent $x.xx"

Actual Result:

Shows "approver email address spent $x.xx"
reportID: 2716853747469889

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Shows "approver email address spent $x.xx"

What is the root cause of that problem?

We get the payerOrApproverName which is the approver of the expense report

App/src/libs/ReportUtils.ts

Lines 2075 to 2076 in ffa731a

	const payerOrApproverName =
	isExpenseReport(report) && !hasNonReimbursableTransactions(report?.reportID ?? '') ? getPolicyName(report, false, policy) : getDisplayNameForParticipant(report?.managerID) ?? '';

and use this for the case hasNonReimbursableTransactions here

App/src/libs/ReportUtils.ts

Line 2094 in ffa731a

return Localize.translateLocal('iou.payerSpentAmount', {payer: payerOrApproverName, amount: formattedAmount});

What changes do you think we should make in order to solve the problem?

For the hasNonReimbursableTransactions case, we should get the name of the employee through report.ownerAccountID and use it instead of payerOrApproverName

if (hasNonReimbursableTransactions(report?.reportID) || true) {
    const employeeName = getDisplayNameForParticipant(report?.ownerAccountID) ?? '';
    return Localize.translateLocal('iou.payerSpentAmount', {payer: employeeName, amount: formattedAmount});
}

OPTIONAL: We can change the name of the translation key to employeeSpentAmount and change the payer param to employee to match its meaning

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@kevinksullivan, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@kevinksullivan, @grgia Huh... This is 4 days overdue. Who can take care of this?

[kevinksullivan]

@grgia have you had a change to look at this?