[HOLD for payment July 7] Focus mode - Show draft messages in #focus

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Upwork link: https://www.upwork.com/jobs/~0130bb846f8492f917

---

Action Performed:

Scenario 1

1. Log in to e.cash
2. Navigate to a conversation and type a message (do not send it)
3. Navigate to LHN
4. Navigate to Preferences
5. Enable focus mode
6. Navigate to LHN

Expected Result:

User should be able to see drafted messages in #focus mode

Actual Result:

Drafted messages are not displayed in focus mode.

Workaround:

N/A

Platform:

Where is this issue occurring?

Web ✔️
iOS✔️
Android✔️
Desktop App✔️
Mobile Web✔️

Version Number: 1.0.74-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Expensify/Expensify Issue URL:

View all open jobs on Upwork

---

From @quinthar https://expensify.slack.com/archives/C01GTK53T8Q/p1624655927132900

When in #focus mode, draft messages should remain in the LHN even when you navigate away, even if the chat itself isn't pinned. However, if you write a message in an unpinned chat and then navigate away before sending, the chat is removed from the LHN.

[MelvinBot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @Jag96 (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[parasharrajat]

Proposal

1. For this we need to check if a report has a draft message then prevent it from being filtered from the list here https://github.com/Expensify/Expensify.cash/blob/a1c742c194084b6b65c3f29225d25d3cfe08cce4/src/libs/OptionsListUtils.js#L302.

To do the above
2. First, we will add a config option to getOptions named as showReportsWithDraft at https://github.com/Expensify/Expensify.cash/blob/a1c742c194084b6b65c3f29225d25d3cfe08cce4/src/libs/OptionsListUtils.js#L259
3. Then inside getOptions we check for the draft message as

const hasDraftComment = report
        && draftComments
        && lodashGet(draftComments, `${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${report.reportID}`, '').length > 0;

we already have draftComments available using here.
4. Now we add this check in the condition at https://github.com/Expensify/Expensify.cash/blob/a1c742c194084b6b65c3f29225d25d3cfe08cce4/src/libs/OptionsListUtils.js#L302.

        const shouldNotFilterReportIfHasDraft = showReportsWithDraft && hasDraftComment;
       if (!shouldNotFilterReportIfHasDraft && report.reportID !== activeReportID && !report.isPinned && shouldFilterReport) {

5. If we have GSD mode, we set this flag to true for getSidebarOptions here.
   https://github.com/Expensify/Expensify.cash/blob/a1c742c194084b6b65c3f29225d25d3cfe08cce4/src/libs/OptionsListUtils.js#L561

[thienlnam]

@parasharrajat The proposal looks great, 🟢 from me - @Jag96 could you please hire @parasharrajat in upwork?

[Jag96]

Posted to Upwork and invited @parasharrajat to the job!