[HOLD for payment 2024-05-09] [$250] Chat - PDF is displayed closer to the top

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.47-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): vdargentotest+mweb030424@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team

Action Performed:

Pre-requisite: the user must be logged in.

1. Go to any chat.
2. Send the attached PDF.
3. Tap on the PDF preview to open it.
4. Verify it is displayed closer to the top.

Expected Result:

The PDF should be displayed in the middle of the viewer section.

Actual Result:

The PDF is displayed closer to the top.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6402389_1709617684018!pdf.pdf

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012ce46bd1a9c35b0c
• Upwork Job ID: 1767225873928306688
• Last Price Increase: 2024-03-18
• Automatic offers:
• mollfpr | Reviewer | 0
• abzokhattab | Contributor | 0

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[izarutskaya]

@sakluger I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[sakluger]

@Expensify/design this is a bug, right? I assume we want images to be vertically center-aligned.

[shawnborton]

Hmm I'm not entirely sure... it's a PDF, and I think I would expect viewing a document to be aligned to the top. Curious what others think though.

[shawnborton]

@izarutskaya can you help us understand why you decided that this was a bug?

[dannymcclain]

I'm honestly not sure about this one. It looks like if a PDF will fit in the viewport, we center it. If it's too long, we align it to the top and let you scroll to see the whole thing?

[shawnborton]

Yeah that's fair... this is also a super tricky PDF because the PDF itself is cropped:

[dannymcclain]

Here's a screenshot of that attachment from the app. I feel like this is how we'd expect it to display.

[shawnborton]

Yeah, that makes sense to me. So it seems like this is just an mWeb thing?

[dannymcclain]

Yeah that's what it looks like to me.

[sakluger]

@shawnborton @dannymcclain, just to confirm, are you saying that this is an mWeb bug, or that it's expected mWeb behavior?