[HOLD for payment 2024-04-05] [$500] Workspace - If title is changed offline, the description is no longer greyed out

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.44-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): applausetester+emilio@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Access staging.new.expensify.com
2. Sign into a valid account
3. Go to any Workspace setting
4. Turn off the internet and change the Description (Note that the text will be greyed out)
5. Still offline, change the title of the WS and observe the description

Expected Result:

User expects the Description to continued greyed out until internet is back online

Actual Result:

The description text turns "normal black" after editing the WS name offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393511_1709000031734.WS_Description_is_no_longer_greyed_out.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a5b48695496946bf
• Upwork Job ID: 1765718526440808448
• Last Price Increase: 2024-03-07

Issue Owner

Current Issue Owner: @rushatgabhane

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

We think that this bug might be related to #wave8
CC @zanyrenney

[lanitochka17]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - If title is changed offline, the description is no longer greyed out

What is the root cause of that problem?

Here we use SET which removes the other pending fields.

App/src/libs/actions/Policy.ts

Line 1094 in 15cf6ad

onyxMethod: Onyx.METHOD.SET,

What changes do you think we should make in order to solve the problem?

Spread current pendingFields along with the new one.

                pendingFields: {
                    ...policy.pendingFields,
                    ...updatedFields
                },

We should also do the same with the errors field and this needs to be updated in updateWorkspaceDescription & updateGeneralSettings. There might be other util functions also so we will also make sure that they are also updated like this. In updateWorkspaceDescription we need to get policy using const policy = allPolicies?.[${ONYXKEYS.COLLECTION.POLICY}${policyID}];.

Also, this need to be done for optimisticData , finallyData & failureData.

Result

pending_fields_grayed_out.mp4

[melvin-bot]

@sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sonialiap]

Reproducible. I've asked in slack if we want to add it to #vip-split

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a5b48695496946bf