[HOLD for payment 2024-03-18] [$500] Still can access to Tag page when request money to DM 1:1 chat

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.43-15
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @DylanDylann
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1708850630563619

Action Performed:

1. Request money
2. Enter amount
3. Select DM 1:1 chat
4. Click on description page
5. In the URL, change description to category or tag/1
   (on native app or desktop app, using deeplink)

Expected Result:

Should display Not Found Page

Actual Result:

Empty category/tag page display

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-02-25.at.15.40.13.mov

View all open jobs on GitHub

Recording.2778.mp4

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019d915d40b791c907
• Upwork Job ID: 1762132134901731328
• Last Price Increase: 2024-02-26
• Automatic offers:
• mkhutornyi | Reviewer | 0
• DylanDylann | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019d915d40b791c907

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Still can access to Tag page when request money to DM 1:1 chat

What is the root cause of that problem?

In IOURequestStepTag we don't pass shouldShowNotFoundPage props to StepScreenWrapper

What changes do you think we should make in order to solve the problem?

In IOURequestStepTag we should pass shouldShowNotFoundPage props to StepScreenWrapper

    const shouldShowNotFoundPage = !isPolicyExpenseChat || (!transactionTag && !OptionsListUtils.hasEnabledTags(policyTagLists)));

App/src/pages/EditRequestPage.js

Line 158 in 6cd008e

if (fieldToEdit === CONST.EDIT_REQUEST_FIELD.TAG && shouldShowTags) {

Like we did here

App/src/pages/EditRequestPage.js

Line 92 in 6cd008e

const shouldShowTags = useMemo(() => isPolicyExpenseChat && (transactionTag || OptionsListUtils.hasEnabledTags(policyTagLists)), [isPolicyExpenseChat, policyTagLists, transactionTag]);

What alternative solutions did you explore? (Optional)

[lschurr]

Could you review this one @mkhutornyi?

[mkhutornyi]

Category, tag cases were fixed in #35458 but there's still inconsistency issue.

Category page shows not found page on RHP but tage page shows in full screen

@lschurr can we fix here?