[HOLD for payment 2024-03-19] [$500] [Held Requests] Hold request modal does not dismiss for Employee after admin pays the request

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Found when validating PR : #33897

Version Number: v1.4.43-6
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal team
Slack conversation:

Action Performed:

Precondition:
Admin and employee are in the same workspace.

1. [Employee] Create a manual request from workspace chat.
2. [Employee] Submit the request.
3. [Employee] Go to request details page.
4. [Employee] Click 3-dot menu > Hold request.
5. [Admin] Pay the request.
6. [Employee] After the background shows "paid", add a reason and submit it.

Expected Result:

In Step 5, Hold Request modal should dismiss for Employee after Admin pays it.

Actual Result:

In Step 5, Hold Request modal does not dismiss for Employee after Admin pays it. As a result, employee can hold the paid request.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6386751_1708514994509.bandicam_2024-02-21_04-11-41-368.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dad4e5f90367adf7
• Upwork Job ID: 1760292458905010176
• Last Price Increase: 2024-02-28
• Automatic offers:
• alitoshmatov | Reviewer | 0
• WikusKriek | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01dad4e5f90367adf7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.