[$500] Chat is showing bold in the LHN for the sender

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.42-4
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1708372588901089

Action Performed:

1. Send a chat to user A
2. Quickly navigated to another chat
3. Observe chat with user A shows as bold and unread, even though you were the one who sent the last message.

If the above doesn't work, vary the speed in which you 'quickly navigate to another chat'? I've been able to reproduce it by very-quickly navigating sometimes, other times I've had to wait a second then navigate to another chat.

Expected Result:

Chat I sent to user A to NOT show as bold

Actual Result:

Chat is bold

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

2024-02-20_13-06-17.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014244c90b04778060
• Upwork Job ID: 1760124228381077504
• Last Price Increase: 2024-02-21

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014244c90b04778060

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[mallenexpensify]

Updated reproducible steps in OP, removed Needs Reproduction, added External label and adding to #vip-vsb.

@mananjadhav please prioritize this. Also, please try to reproduce and post your results.

Internal thread in #vip-vsb about too @isabelastisser

[jeremy-croff]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We should never show the LHN as bold when the sender sends the message.

What is the root cause of that problem?

We do a naive timestamp comparison when we determine if something is unread. This has an underlying assumption that the sender has the current chat open, so the report's last read timestamp will match the last sent timestamp. This logic fails under the reproducible steps of this ticket.

What changes do you think we should make in order to solve the problem?

We can enhance the current isUnread logic to consider the sender of the last message so that it won't mark it as unread if the sender is me.

report.lastActorAccountID !== currentUserAccountID; are variables available in this scope.

What alternative solutions did you explore? (Optional)