Skip to content

[No BZ] Warn developers if they upgrade a dependency but not a patch #36776

Description

@roryabraham

Coming from #36775...

Problem

When upgrading dependencies, it's possible that you may break a patch for that dependency. It's also possible that the patch may no longer be needed. It's easy to forget this, which leaves unused patch files in our repo.

Solution

Add a simple PR check to our webhook that looks for PRs that upgrade a dependency with a patch without updating the patch and include a PR comment like:

Heads up! It looks like you updated a dependency without updating the patch. Do you need to update the patch?

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019999ca1782dc1db6
  • Upwork Job ID: 1759309916923375616
  • Last Price Increase: 2024-02-18

Metadata

Metadata

Assignees

Labels

FirstPickEngineering only, please! Only add when there is an identified code solution.InternalRequires API changes or must be handled by Expensify staffMonthlyKSv2NewFeatureSomething to build that is a new item.Not a priorityReviewingHas a PR in review

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions