Skip to content

[HOLD for payment 2024-04-05] [$100] Remove the closeFullScreen() method from code since it is no longer used #36509

Description

@kbecciv

The back button was removed from the modals and so now the closeFullScreen() method is no longer used in the code, but it was never removed. Let's remove it!

Old Issue Description If you haven’t already, check out our [contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/contributingGuides/CONTRIBUTING.md) for onboarding and email contributors@expensify.com to request to join our Slack channel! ___

Version Number: v1.4.41-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal
Slack conversation:

Action Performed:

Precondition:

  • Workspace filter is set to "Expensify".
  1. Go to staging.new.expensify.com
  2. Go to any chat and send a message.
  3. Open workspace switcher.
  4. Select any workspace.
  5. Click Profile settings.
  6. Click back button on the top left.

Expected Result:

App closes profile settings and reopens the chat that shows up after switching workspace in Step 4.

Actual Result:

App reopens the chat that is opened in Step 2, which is before workspace filter is applied, while the workspace filter is still applied.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6379359_1707916511910.20240214_185244.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0124a682d645bc91de
  • Upwork Job ID: 1757785433393643520
  • Last Price Increase: 2024-03-15
Issue OwnerCurrent Issue Owner: @adelekennedy

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Fields

No fields configured for issues without a type.

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions