[$500] Infinite loading when accessing a non-existing workspace

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.41-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @hayata-suenaga
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707848696684749

Action Performed:

1. Log out
2. Go to some WS link, e.g. https://staging.new.expensify.com/workspace/adsasddssad/rateandunit (doesn't matter if policy exist or not)
3. Log in

Expected Result:

Shouldn't be infinite loading

Actual Result:

Infinite loading appears

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019c756122ca1f4027
• Upwork Job ID: 1757527427083399168
• Last Price Increase: 2024-02-13
• Automatic offers:
• fedirjh | Reviewer | 0
• bernhardoj | Contributor | 0

Issue Owner

Current Issue Owner: @fedirjh

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019c756122ca1f4027

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[abzokhattab]

the issue is not reproducible on the latest main.

[kosmydel]

the issue is not reproducible on the latest main.

I can still reproduce it.

[hayata-suenaga]

I can also still reproduce this

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

If we open a nonexistent workspace page after login, the app will load indefinitely.

What is the root cause of that problem?

When we open a nonexistent workspace page after login, the OpenApp request is never called. It will only be called if isReadyToOpenApp promise is resolved.

App/src/libs/actions/App.ts

Line 151 in 574157e

isReadyToOpenApp.then(() => {

App.confirmReadyToOpenApp is used to resolve the promise and it currently is called in both ReportScreenIDSetter and SidebarLinks. When we open the workspace page after login, the report screen isn't added to the navigation stack, so App.confirmReadyToOpenApp is never called in ReportScreenIDSetter.

In SidebarLinks, App.confirmReadyToOpenApp is called only on small screen.

App/src/pages/home/sidebar/SidebarLinks.js

Lines 54 to 59 in b0b651b

	useEffect(() => {
	if (!isSmallScreenWidth) {
	return;
	}
	App.confirmReadyToOpenApp();
	}, [isSmallScreenWidth]);

Because the promise isn't resolved, the app shows the loading indicator infinitely.

What changes do you think we should make in order to solve the problem?

SidebarLinks is placed inside the bottom tab navigator which is always exist in the nav stack, so I think we can just have one place to call App.confirmReadyToOpenApp inside SidebarLinks. So, we can just remove the small screen condition.

App/src/pages/home/sidebar/SidebarLinks.js

Lines 54 to 59 in b0b651b

	useEffect(() => {
	if (!isSmallScreenWidth) {
	return;
	}
	App.confirmReadyToOpenApp();
	}, [isSmallScreenWidth]);

[fedirjh]

When we open the workspace page after login, the report screen isn't added to the navigation stack, so App.confirmReadyToOpenApp is never called in ReportScreenIDSetter.

@bernhardoj Your proposal makes sense. I am just wondering why ReportScreenIDSetter is never mounted? is it mounted after the reports are loaded? And are the reports loaded after OpenApp is called?