[HOLD for payment 2024-02-26] [$500] Expense - "Recent" and "All" appear in report field selection list when there is no result

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: .1.4-36.1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition:

• User is an employee of Collect workspace
• The Collect workspace has dropdown field set up in "Report and Invoice Fields" on Old Dot

1. Go to workspace chat
2. Create a request
3. Go to expense report
4. Click on the report field with the selection list set up from Old Dot
5. Search for an invalid term
   Note that "Recent" and "All" appear when there are no relevant results

Expected Result:

In Step 4, when there is no recent item, "Recent" will not appear in the list
In Step 5, when there is no search result, "Recent" and "All" will not appear in the list

Actual Result:

In Step 4, when there is no recent item, "Recent" appears in the list
In Step 5, when there is no search result, "Recent" and "All" also appear in the list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6367962_1707149161081.bandicam_2024-02-05_21-13-05-298__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d9bb73088604e957
• Upwork Job ID: 1754584397767528448
• Last Price Increase: 2024-02-05
• Automatic offers:
• Amarparab2024 | Contributor | 0

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #wave6
CC @greg-schroeder

[aeioual]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Recent" and "All" appear in report field selection list when there is no result

What is the root cause of that problem?

We have a condition to always show the recents regardless of the list being empty

App/src/pages/EditReportFieldDropdownPage.tsx

Line 54 in 34330e2

shouldShow: true,

What changes do you think we should make in order to solve the problem?

Update the function to only show the recents if the list is not empty

shouldShow: !_.isEmpty(recentlyUsedOptions)

We already do that at other places

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Line 166 in 34330e2

shouldShow: !_.isEmpty(newChatOptions.recentReports),

Same approach will be followed for All list

What alternative solutions did you explore? (Optional)

N/A

[mountiny]

Not a blocker, this is behind beta cc @thienlnam @allroundexperts