[HOLD for payment 2024-02-01] [$500] Android - Add bank account - Choose an account hardly visible when light them applied

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.30-0
Reproducible in staging?: Y
Reproducible in production?: No, unable to check prod
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4228288
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: the light mode has been applied

1. Open the app and log in
2. Navigate to any workspace settings > Bank account > Connect online with Plaid or Wallet > Add bank account > Personal bank account
3. Select e.g. Wells Fargo and continue with credentials
4. Select Checking and Savings accounts
5. Finish with the Plaid flow
6. On the Add bank account page open the selector

Expected Result:

The text in the modal is fully visible

Actual Result:

"Choose an account" is hardly visible

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017d11e22a4c76ac05
• Upwork Job ID: 1750031291554013184
• Last Price Increase: 2024-01-24
• Automatic offers:
• mollfpr | Reviewer | 28118930
• mkhutornyi | Contributor | 28118931

[melvin-bot]

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #vip-split-p2p-chat-groups

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Add bank account - Choose an account hardly visible when light them applied

What is the root cause of that problem?

In #33194, we applied platform specific text color in each item but missed picker title (placeholder)

What changes do you think we should make in order to solve the problem?

App/src/components/Picker/BasePicker.tsx

Line 54 in b31ea3a

const pickerPlaceholder = Object.keys(placeholder).length > 0 ? {...placeholder, color: theme.text} : {};

use itemColor instead of theme.text

[thienlnam]

@mkhutornyi Are you around to handle this?