[HOLD for payment 2024-03-07] [$500] [MEDIUM] Scan - Merchant message disappears after deleting receipt and reappears after adding receipt

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.30-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to workspace chat
2. Create a scan request
3. While the scanning is ongoing, navigate to the request details page and manually enter amount
4. Click on the receipt and delete it
5. Add a receipt

Expected Result:

Since merchant is a requirement for workspace request, the merchant requirement message will remain until a merchant is entered

Actual Result:

After deleting the receipt while merchant is empty, the merchant message disappears. After adding a receipt, the message reappears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6352447_1706038465358.20240123_234633.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f34025c8418af8d7
• Upwork Job ID: 1749884467102949376
• Last Price Increase: 2024-01-23
• Automatic offers:
• c3024 | Reviewer | 28142586
• dukenv0307 | Contributor | 28142587

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f34025c8418af8d7

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[lanitochka17]

We think that this bug might be related to #wave6.
CC @greg-schroeder

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Merchant error message disappeared even it's a policy chat

What is the root cause of that problem?

The problem starts here

App/src/components/ReportActionItem/MoneyRequestView.js

Lines 222 to 226 in 872eb17

	let hasErrors = false;
	if (hasReceipt) {
	receiptURIs = ReceiptUtils.getThumbnailAndImageURIs(transaction);
	hasErrors = canEdit && TransactionUtils.hasMissingSmartscanFields(transaction);
	}

hasErrors is true when we have required empty fields after scanning. When we delete a receipt, hasReceipt becomes false, indicating that the corresponding hasErrors will also be false, and no error will be displayed.

App/src/components/ReportActionItem/MoneyRequestView.js

Line 317 in 872eb17

error={hasErrors && isPolicyExpenseChat && isEmptyMerchant ? translate('common.error.enterMerchant') : ''}

What changes do you think we should make in order to solve the problem?

We can change this to

App/src/components/ReportActionItem/MoneyRequestView.js

Line 317 in 872eb17

error={hasErrors && isPolicyExpenseChat && isEmptyMerchant ? translate('common.error.enterMerchant') : ''}

error={!TransactionUtils.isReceiptBeingScanned(transaction) && isPolicyExpenseChat && isEmptyMerchant ? translate('common.error.enterMerchant') : ''}

The error will be displayed only when we don't have a receipt being scanned, and it is a policy expense chat and merchant is empty.

What alternative solutions did you explore? (Optional)

We can add another check !TransactionUtils.isReceiptBeingScanned(transaction) here

App/src/components/ReportActionItem/MoneyRequestView.js

Line 317 in 872eb17

error={hasErrors && isPolicyExpenseChat && isEmptyMerchant ? translate('common.error.enterMerchant') : ''}

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Scan - Merchant message disappears after deleting receipt and reappears after adding receipt

What is the root cause of that problem?

• Here is the condition that we use to display the merchant error. In this bug, hasErrors field is false because we just set it to true in:
  

  App/src/components/ReportActionItem/MoneyRequestView.js

  Lines 223 to 226 in 872eb17

  	if (hasReceipt) {
  	receiptURIs = ReceiptUtils.getThumbnailAndImageURIs(transaction);
  	hasErrors = canEdit && TransactionUtils.hasMissingSmartscanFields(transaction);
  	}

• When we delete the receipt, the hasReceipt is false, that leads to the above logic is not called

What changes do you think we should make in order to solve the problem?

• We need to have a way to differentiate manual requests with an attached receipt from a smartscan request once the server returns the response.
• Then, just need to update:
  

  App/src/components/ReportActionItem/MoneyRequestView.js

  Lines 222 to 226 in 872eb17

  	let hasErrors = false;
  	if (hasReceipt) {
  	receiptURIs = ReceiptUtils.getThumbnailAndImageURIs(transaction);
  	hasErrors = canEdit && TransactionUtils.hasMissingSmartscanFields(transaction);
  	}

  
  to:

    let hasErrors = false
    if (hasReceipt) {
        receiptURIs = ReceiptUtils.getThumbnailAndImageURIs(transaction);
    }
    if(isScanRequest){
        hasErrors = canEdit && TransactionUtils.hasMissingSmartscanFields(transaction);
    }

• In the above, isScanRequest can be returned from BE side

What alternative solutions did you explore? (Optional)

• Also, we just need to update:
  

  App/src/components/ReportActionItem/MoneyRequestView.js

  Lines 222 to 226 in 872eb17

  	let hasErrors = false;
  	if (hasReceipt) {
  	receiptURIs = ReceiptUtils.getThumbnailAndImageURIs(transaction);
  	hasErrors = canEdit && TransactionUtils.hasMissingSmartscanFields(transaction);
  	}

  
  to:

    let hasErrors = false
    if (hasReceipt) {
        receiptURIs = ReceiptUtils.getThumbnailAndImageURIs(transaction);
    }
    hasErrors = canEdit && TransactionUtils.hasMissingSmartscanFields(transaction);

[dukenv0307]

@c3024 What do you think about my proposal here?