[HOLD for Payment 2024-03-04][$500] Focus mode - User priority mode is switched back to focus automatically

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.28-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @sakluger
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705600042656339

Action Performed:

Precondition: Must be reproduced in a user who switched to Focus mode before the 'auto-switch to Focus mode' was added

1. Login with the user
2. Change the priority mode to Most recent

Expected Result:

Priority mode should not change automatically

Actual Result:

Priority mode changes back to Focus without the user requesting it.

@sakluger comments provide more info on this:

Main comment: For users who switched to Focus mode before we added 'auto-switch to Focus mode', if you switch to Most Recent mode, then you'll get switched back to focus mode immediately. In other words, everyone gets automatically switched to focus mode once, even if you've already been using focus mode.

Another comment on the reproduction: This one is a little tricky to test - it requires having an account where you already switched to focus mode long ago (like over a month ago) and where you haven't switched back to most recent since then. I've confirmed that it happens on three different Expensify employee accounts, so it's definitely reproduceable.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-01-18.at.9.35.16.AM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e23bd51930a48b60
• Upwork Job ID: 1748378128953937920
• Last Price Increase: 2024-01-19
• Automatic offers:
• cubuspl42 | Reviewer | 28117804
• tienifr | Contributor | 28117805

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e23bd51930a48b60

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Priority mode changes back to Focus without the user requesting it.

What is the root cause of that problem?

In here, we only update NVP_TRY_FOCUS_MODE to true if the user got automatically switched to focus mode. This doesn't cover the case where the user already tried focus mode before.

What changes do you think we should make in order to solve the problem?

Update NVP_TRY_FOCUS_MODE to true whenever user changes from focus mode to most recent mode as well, because that means the user already tried focus mode before.

I think we can actually remove this condition because if the updateChatPriorityMode, that means the user already tried the focus mode. There're 3 cases when updateChatPriorityMode is called:

1. The user manually changes from most recent mode to focus mode. The user tried it themselves so it makes sense for NVP_TRY_FOCUS_MODE to be true so we won't show the #focus mode introduction again
2. The user was an old user before we added 'auto-switch to Focus mode', now they change to Most recent mode, in this case the user already tried the focus mode so it makes sense for NVP_TRY_FOCUS_MODE to be true
3. The user was automatically changed to focus mode.

In all 3 cases NVP_TRY_FOCUS_MODE should be true so there's no need for that condition.

What alternative solutions did you explore? (Optional)

NA

[anmurali]

@cubuspl42 - can you review the proposal above please?

[jakub-trzebiatowski]

@tienifr

Makes sense!

I approve the proposal by @tienifr

C+ reviewed 🎀 👀 🎀