[HOLD for payment 2024-02-14] [$500] Request money - "No results found" shows up when searching for a valid and existing contact

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.26-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Copy a valid and existing contact
2. Go to FAB > Request money > Manual
3. Enter amount > Next
4. Paste the contact email

Expected Result:

It will not show "No results found" since the email is a valid and existing contact.

Actual Result:

It shows "No results found" while the search result is right under it

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6345433_1705506882382.bandicam_2024-01-17_22-33-58-851.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f0e4e8b2a45735bd
• Upwork Job ID: 1747657251425345536
• Last Price Increase: 2024-01-24

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f0e4e8b2a45735bd

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No result found when searching participant even though there is a result.

What is the root cause of that problem?

We are taking the header message with below logic.

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Lines 230 to 232 in 4097c00

	() =>
	OptionsListUtils.getHeaderMessage(
	_.get(newChatOptions, 'personalDetails.length', 0) + _.get(newChatOptions, 'recentReports.length', 0) !== 0,

The first param always evaluates to false because we get the property wrongly. We use undersore.get function but for the nested property, we need to use an array instead of a single string.

Because the first param (hasSelectableOptions) is always false, we get the no result found message.

App/src/libs/OptionsListUtils.js

Line 1865 in 4097c00

function getHeaderMessage(hasSelectableOptions, hasUserToInvite, searchValue, maxParticipantsReached = false, hasMatchedParticipant = false) {

App/src/libs/OptionsListUtils.js

Lines 1880 to 1891 in 4097c00

	if (searchValue && !hasSelectableOptions && !hasUserToInvite) {
	if (/^\d+$/.test(searchValue) && !isValidPhone) {
	return Localize.translate(preferredLocale, 'messages.errorMessageInvalidPhone');
	}
	if (/@/.test(searchValue) && !isValidEmail) {
	return Localize.translate(preferredLocale, 'messages.errorMessageInvalidEmail');
	}
	if (hasMatchedParticipant && (isValidEmail || isValidPhone)) {
	return '';
	}
	return Localize.translate(preferredLocale, 'common.noResultsFound');
	}

What changes do you think we should make in order to solve the problem?

Use array to access the nested property.

_.get(newChatOptions, ['personalDetails', 'length'], 0) + _.get(newChatOptions, ['recentReports', 'length'], 0) !== 0

or use lodash

I am seeing this. Please check this. I don't see No Result Found

screen-recording-2024-01-17-at-100710-pm_FiEh8fzd.mp4

[ZhenjaHorbach]

@AnshuAgarwal24
Update main

And this looks like a regression from this PR
#34587

@AnshuAgarwal24 Update main

And this looks like a regression from this PR #34587

okay maybe forgot to this

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

It shows "No results found" while the search result is right under it

What is the root cause of that problem?

we use get from underscore but we pass the wrong property (we should pass the array property when we use get from underscore) here which makes hasSelectableOptions param pass to getHeaderMessage function is false and then No result found message appears

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Line 232 in 4097c00

_.get(newChatOptions, 'personalDetails.length', 0) + _.get(newChatOptions, 'recentReports.length', 0) !== 0,

What changes do you think we should make in order to solve the problem?

Because personalDetails and recentReports are always array from getOptions so we don't need to use get here

(newChatOptions.personalDetails.length + newChatOptions.recentReports.length) !== 0,

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Line 232 in 4097c00

_.get(newChatOptions, 'personalDetails.length', 0) + _.get(newChatOptions, 'recentReports.length', 0) !== 0,

What alternative solutions did you explore? (Optional)

NA