[PAID] [$500] Expense - "Enter a merchant" is still shown when the expense is paid

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.24-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. [Member] Go to workspace chat and create a scan request.
2. [Member] Manually enter the amount of the scanning request, while leaving Merchant empty.
3. [Admin] Pay the request.
4. [Admin] Navigate to request details view.

EXPECTED RESULT

The Merchant row will not show "Enter a merchant" since admin can no longer edit the paid expense.

ACTUAL RESULT

The Merchant row shows "Enter a merchant" with a red dot when there is no way to edit merchant for a paid expense

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6339900_1705050248772.bandicam_2024-01-12_02-47-53-164.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018efb2cb983d9645c
• Upwork Job ID: 1749775068612321280
• Last Price Increase: 2024-01-23
• Automatic offers:
• c3024 | Reviewer | 28128948
• DylanDylann | Contributor | 28128950

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Merchant row shows "Enter a merchant" with a red dot when there is no way to edit merchant for a paid expense

What is the root cause of that problem?

App/src/components/ReportActionItem/MoneyRequestView.js

Line 317 in b6a18b1

error={hasErrors && isEmptyMerchant ? translate('common.error.enterMerchant') : ''}

In here we don't check if the request money is paid or not

What changes do you think we should make in order to solve the problem?

We shouldn't show error if the request is paid or cancelled

App/src/components/ReportActionItem/MoneyRequestView.js

Line 317 in b6a18b1

error={hasErrors && isEmptyMerchant ? translate('common.error.enterMerchant') : ''}

error={!isSettled && !isCancelled && hasErrors && isEmptyMerchant ? translate('common.error.enterMerchant') : ''}

We also update the same thing with brickRoadIndicator

App/src/components/ReportActionItem/MoneyRequestView.js

Line 316 in b6a18b1

brickRoadIndicator={hasViolations('merchant') || (hasErrors && isEmptyMerchant) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : ''}

brickRoadIndicator={hasViolations('merchant') || (!isSettled && !isCancelled && hasErrors && isEmptyMerchant) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : ''}

Or (depend on the expected)

brickRoadIndicator={!isSettled && !isCancelled && (hasViolations('merchant') || (hasErrors && isEmptyMerchant)) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : ''}

What alternative solutions did you explore? (Optional)

NA

[strepanier03]

Hmmm, gonna think about this one and likely raise it, then circle back Tuesday next week when I'm back in office.

[melvin-bot]

@strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[strepanier03]

Update tomorrow.

[strepanier03]

All right, repro'd and raised in Slack here.