[Paid] [$500] Expense - Red dot for WS chat in LHN remains when admin pays a Scan request with no merchant

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.21-4
Reproducible in staging?: Y
Reproducible in Production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to workspace chat as workspace member
2. Create a Scan request
3. Go to details page of the request
4. Click Amount > enter amount > Save
5. As admin, pay the request

Expected Result:

The red dot in LHN for the workspace chat will be dismissed from member view

Actual Result:

The red dot in LHN for the workspace chat is not dismissed from member view

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6332214_1704379600800.20240104_090851.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fdd2abc895c5a2d0
• Upwork Job ID: 1743086417081118720
• Last Price Increase: 2024-01-05
• Automatic offers:
• c3024 | Reviewer | 28089727
• dukenv0307 | Contributor | 28089728

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fdd2abc895c5a2d0

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The red dot in LHN for the workspace chat is not dismissed from member view

What is the root cause of that problem?

We are not checking whether the IOU report is settled or not in hasSmartscanError function

App/src/libs/ReportUtils.ts

Line 4243 in 2d455bf

const isReportPreviewError = ReportActionsUtils.isReportPreviewAction(action) && hasMissingSmartscanFields(ReportActionsUtils.getIOUReportIDFromReportActionPreview(action));

App/src/libs/OptionsListUtils.js

Line 366 in 2d455bf

} else if (ReportUtils.hasSmartscanError(_.values(reportActions))) {

What changes do you think we should make in order to solve the problem?

We should add the settled check for this case

const IOUReportID = ReportActionsUtils.getIOUReportIDFromReportActionPreview(action);
const isReportPreviewError = ReportActionsUtils.isReportPreviewAction(action) && hasMissingSmartscanFields(IOUReportID) && !isSettled(IOUReportID);

App/src/libs/ReportUtils.ts

Line 4243 in 2d455bf

const isReportPreviewError = ReportActionsUtils.isReportPreviewAction(action) && hasMissingSmartscanFields(ReportActionsUtils.getIOUReportIDFromReportActionPreview(action));

What alternative solutions did you explore? (Optional)

NA

[c3024]

@dukenv0307 's proposal here looks good to me.

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @mountiny, see https://stackoverflow.com/c/expensify/questions/7972 for more details.