[$500] IOU - No error message when changing amount of a paid request

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.20-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. [User A] Request money from User B.
2. [User A] Open IOU details page > Click Amount.
3. [User B] Pay the request.
4. [User A] Enter a new amount and save it.

Expected Result:

Error message "Unexpected error editing the money request, please try again later" will show up when editing the amount of a settled request.

Actual Result:

Error message does not show up.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6328897_1703905910295.bandicam_2023-12-30_03-16-45-208.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01064a73e07695ea66
• Upwork Job ID: 1741171439973834752
• Last Price Increase: 2023-12-30
• Automatic offers:
• fedirjh | Reviewer | 28077812
• Pujan92 | Contributor | 28077813

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01064a73e07695ea66

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU - No error message when changing amount of a paid request

What is the root cause of that problem?

This happens as we don’t check if the request is paid before calling IOU.updateMoneyRequestAmountAndCurrency here:



App/src/pages/EditRequestPage.js

Lines 123 to 136 in 8cb48e4

	const saveAmountAndCurrency = useCallback(
	({amount, currency: newCurrency}) => {
	const newAmount = CurrencyUtils.convertToBackendAmount(Number.parseFloat(amount));
	// If the value hasn't changed, don't request to save changes on the server and just close the modal
	if (newAmount === TransactionUtils.getAmount(transaction) && newCurrency === TransactionUtils.getCurrency(transaction)) {
	Navigation.dismissModal();
	return;
	}
	IOU.updateMoneyRequestAmountAndCurrency(transaction.transactionID, report.reportID, newCurrency, newAmount);
	Navigation.dismissModal();
	},
	[transaction, report],

What changes do you think we should make in order to solve the problem?

We should add a check to see if the request is paid using ReportUtils.canEditFieldOfMoneyRequest()
 here:

App/src/pages/EditRequestPage.js

Lines 127 to 131 in 8cb48e4

	// If the value hasn't changed, don't request to save changes on the server and just close the modal
	if (newAmount === TransactionUtils.getAmount(transaction) && newCurrency === TransactionUtils.getCurrency(transaction)) {
	Navigation.dismissModal();
	return;
	}

We could also use ReportUtils.isSettled() for the check.

Alternatively:

• We can add the check in IOU.updateMoneyRequestAmountAndCurrency here.

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

The backend is returning the correct error message, however we don't expect it because we are not handling it in the MoneyRequestView.

What changes do you think we should make in order to solve the problem?

Get the errors from the errorFields and set it as the errors prop for the OfflineWithFeedback. The error message should not persist. Therefore, we can delete from the onyx once the user navigates away from the page or onClose. However, if we need them for later, we can also shouldShowErrorMessages if the latest error message is past a certain duration.

App/src/components/ReportActionItem/MoneyRequestView.js

Lines 201 to 202 in 8cb48e4

	<OfflineWithFeedback pendingAction={getPendingFieldAction('pendingFields.amount')}>
	<MenuItemWithTopDescription

errors={getLatestAmountCurrencyErrors()}

Pseudo-code

function getLatestAmountCurrencyErrors(){
 errors = lodashGet(transaction, 'errorFields.amount') || lodashGet(transaction, 'errorFields.currency')
 errors.sort() // If needed 
 return errors.length > 0 ? errors[0] : null
}

What alternative solutions did you explore? (Optional)

1. Create a parent OfflineWithFeedback component of MoneyRequestView. Then, use the transaction.error value for the errors prop of the component.

2. Listen for the transaction and disable the save button once it's paid. Also, displays an error.

[MitchExpensify]

The expected result is weird to me, why would we tell the user an "unexpected error" occurs if it's expected that you cannot edit a settled amount? Why don't we just tell the user they cannot edit a settled amount if that is indeed expected?