[HOLD for payment 2023-12-20] Split - Adding a receipt to a manual split request turns it into a scan split request

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.11-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com.
2. Click FAB button > + > Request money.
3. Enter amount > Next.
4. Click Split next to a few users > Next.
5. On the confirmation page, click 3-dot menu > Add a receipt.
6. Upload a photo and create the request.

Expected Result:

The manual split request will remain as a manual split request.

Actual Result:

The manual split request becomes a Scan split request after adding a receipt.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6309230_1702310650875.20231211_232012.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[luacmartins]

I can reproduce this, but it seems like we don't have the option to add a receipt to a split request in prod at all.

[luacmartins]

We CPed a fix. Closing.