[$500] Login – Doesn't redirect to Login page with an error message when reusing email link.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.3.99-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Signout of NewDot.
3. Log into staging.expensify.com with any account.
4. Add a Secondary Login from Account Settings.
5. Open "validate secondary log in" email .
6. Copy the link under "Click here to validate that login, like magic!" (e.g. https://staging.expensify.com/v/3431989/123456).
7. Paste the URL into new tab (don't enter it yet).
8. Add "new" after staging (e.g. https://staging.new.expensify.com/v/3431989/123456).
9. Navigate to the compiled link.
10. Click on “just sign in here”.
11. Complete login to NewDot.
12. Sign out of NewDot.
13. Reuse the link created in step 9.

Expected Result:

Verify you're redirected to Login page with an error message displayed below the password field stating: "This set password link is invalid or has expired..."

Actual Result:

"Here is your magic code" page opens.
Does not redirect to the Login page with an error message when reusing a link created via OldDot's secondary login email verification.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6277041_1700037932097.Does_not_redirect_to_the_Login_page_with_an_error_message.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01758ec553a03ac819
• Upwork Job ID: 1724765802065883136
• Last Price Increase: 2023-11-29

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01758ec553a03ac819

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[cooldev900]

Proposal

from: @cooldev900

Please re-state the problem that we are trying to solve in this issue.

The ValidateLoginPage does show "Here is your magic code" instead of "Magic code is expired" after used login code.

What is the root cause of that problem?

The root cause is because credentials and session objects are null after signing out so that login becomes null and autoAuthState becomes CONST.AUTO_AUTH_STATE.NOT_STARTED.
Session.signInWithValidateCode can't be called because login is null.

App/src/pages/ValidateLoginPage/index.website.js

Lines 67 to 72 in eb5de8e

	if (isSignedIn || !login) {
	return;
	}
	// The user has initiated the sign in process on the same browser, in another tab.
	Session.signInWithValidateCode(accountID, validateCode);

So we will see "Here is the magic code".

App/src/pages/ValidateLoginPage/index.website.js

Lines 90 to 95 in eb5de8e

	{autoAuthState === CONST.AUTO_AUTH_STATE.NOT_STARTED && (
	<ValidateCodeModal
	accountID={accountID}
	code={validateCode}
	/>
	)}

What changes do you think we should make in order to solve the problem?

We need to call Session.signInWithValidateCode if we already signed in the platform.
We should update this code

App/src/pages/ValidateLoginPage/index.website.js

Lines 67 to 69 in eb5de8e

	if (isSignedIn || !login) {
	return;
	}

to

if (isSignedIn) {
      return;
}

screen-capture.11.mp4

What alternative solutions did you explore? (Optional)

N/A

[shubham1206agra]

@cooldev900 Can you send the current API params and response here?

[cooldev900]

@shubham1206agra
Here is API params and response.
I think backend is updated regarding expired validate code.

[shubham1206agra]

In this case can QA confirm the reproducibility of this issue?