Skip to content

MEDIUM: [$500] Unread indicator is showing in the fevicon even though there is nothing in LHN #31276

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1699899029212629

Action Performed:

  1. Open app and login
  2. Make a IOU request
  3. Open the IOU thread to see the details
  4. Observe the unread indicator in expensify fevicon

Expected Result:

If there is an unread indicator, LHN should have one unread message

Actual Result:

But nothing in LHN with unread message.

it was caused by this transaction thread, which wasn’t showing up in my LHN, but was considered unread by the logic being used to compute the unread indicator here. We should update the logic of the unread indicator to make sure it matches the logic of the LHN (or even better use shared logic). So that it’s never possible to see the unread indicator when you don’t have anything unread in the LHN.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

IMG_0222

image (31)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d98ea368e18737bf
  • Upwork Job ID: 1724168903941550080
  • Last Price Increase: 2024-01-03
Issue OwnerCurrent Issue Owner: @muttmuure

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Fields

No fields configured for issues without a type.

Projects

Status
Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions