[$500] Android - Notes - Cursor is not shown in "Notes" field and text entered is also not displayed.

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.98-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch app
2. Tap on a 1:1 report
3. Tap header
4. Tap private notes
5. Tap My note
6. Tap notes
7. Type any text

Expected Result:

Cursor must be shown in "Notes" field and text entered must be displayed

Actual Result:

Cursor is not shown in "Notes" field and text entered is also not displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6271566_1699639033617.az_recorder_20231110_223302.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c83f6aa2bc7c60c2
• Upwork Job ID: 1723042800626786304
• Last Price Increase: 2023-11-10
• Automatic offers:
• dukenv0307 | Contributor | 27789824

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c83f6aa2bc7c60c2

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Notes - Cursor is not shown in "Notes" field and text entered is also not displayed.

What is the root cause of that problem?

This is due to the fact that we do not pass verticalAlignTop
As a result, the input field is hidden behind the rest of the content

What changes do you think we should make in order to solve the problem?

We can add verticalAlignTop as we made in other places (EditRequestDescriptionPage, MoneyRequestDescriptionPage and other )

Add
inputStyle={[styles.verticalAlignTop]}

for

App/src/pages/PrivateNotes/PrivateNotesEditPage.js

Lines 145 to 169 in ebc35e7

	<InputWrapper
	InputComponent={TextInput}
	role={CONST.ACCESSIBILITY_ROLE.TEXT}
	inputID="privateNotes"
	label={translate('privateNotes.composerLabel')}
	accessibilityLabel={translate('privateNotes.title')}
	autoCompleteType="off"
	maxLength={CONST.MAX_COMMENT_LENGTH}
	autoCorrect={false}
	autoGrowHeight
	containerStyles={[styles.autoGrowHeightMultilineInput]}
	defaultValue={privateNote}
	value={privateNote}
	onChangeText={(text) => {
	debouncedSavePrivateNote(text);
	setPrivateNote(text);
	}}
	ref={(el) => {
	if (!el) {
	return;
	}
	privateNotesInput.current = el;
	updateMultilineInputRange(privateNotesInput.current);
	}}
	/>

Or we can try to add inputStyle by default for InputWrapper

What alternative solutions did you explore? (Optional)

NA

Screen.Recording.2023-11-10.at.19.34.37.mov

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We don’t have inputStyle={[styles.verticalAlignTop]} style for autoGrowHeight input here, so the text input does not show on Android.

What changes do you think we should make in order to solve the problem?

This problem has happened before for some other inputs, we need a more holistic way to solve it once and for all. Since the verticalAlignTop style is always required for the input to display if it has autoGrowHeight, we should add it to BaseTextInput by default if the input has autoGrowHeight. This way we don’t have to add verticalAlignTop individually for those inputs, avoiding unnecessary code and room for error to occur.

After we add that, we can remove the existing verticalAlignTop in the current inputs with autoGrowHeight.

What alternative solutions did you explore? (Optional)

We can fix case-by-case to add verticalAlignTop to PrivateNotesEditPage, but we should replace this by inputStyle={[styles.verticalAlignTop]} as well to avoid the warning on the deprecated prop.

We can additionally consider adding containerStyles={[styles.autoGrowHeightMultilineInput]} as default value in BaseTextInput if the autoGrowHeight is true.

[mananjadhav]

@ZhenjaHorbach's proposal looks good.

🎀 👀 🎀 C+ reviewed.